update(cnl): retina flow logs rename to container network logs #9324
+2,575
−476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_container_network_logs |
||
| aks create | cmd aks create update parameter enable_retina_flow_logs: added property deprecate_info_hide=True |
||
| aks create | cmd aks create update parameter enable_retina_flow_logs: added property deprecate_info_redirect=--enable-container-network-logs |
||
| aks create | cmd aks create update parameter enable_retina_flow_logs: added property deprecate_info_target=--enable-retina-flow-logs |
||
| aks update | cmd aks update added parameter disable_container_network_logs |
||
| aks update | cmd aks update added parameter enable_container_network_logs |
||
| aks update | cmd aks update update parameter disable_retina_flow_logs: added property deprecate_info_hide=True |
||
| aks update | cmd aks update update parameter disable_retina_flow_logs: added property deprecate_info_redirect=--disable-container-network-logs |
||
| aks update | cmd aks update update parameter disable_retina_flow_logs: added property deprecate_info_target=--disable-retina-flow-logs |
||
| aks update | cmd aks update update parameter enable_retina_flow_logs: added property deprecate_info_hide=True |
||
| aks update | cmd aks update update parameter enable_retina_flow_logs: added property deprecate_info_redirect=--enable-container-network-logs |
||
| aks update | cmd aks update update parameter enable_retina_flow_logs: added property deprecate_info_target=--enable-retina-flow-logs |
|
Hi @snguyen64, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @snguyen64 Release SuggestionsModule: aks-preview
Notes
|
snguyen64
force-pushed
the
nguyensteven/cnl-cli-update
branch
from
b79fe49 to
6d80acd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR renames the "retina flow logs" feature to "container network logs" across the AKS preview extension, introducing new CLI parameters while maintaining backward compatibility with deprecated flags.
Key changes:
- Introduces
--enable-container-network-logsand--disable-container-network-logsparameters - Deprecates existing
--enable-retina-flow-logsand--disable-retina-flow-logsparameters - Updates internal function names and test cases to reflect the new terminology
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/linter_exclusions.yml | Adds linter exclusions for the new container network logs parameters |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Renames test function and updates test cases to use new parameter names, adds test for deprecated flag backward compatibility |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Updates integration test to use new CLI parameters and re-enables previously commented test steps |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Renames internal function from get_retina_flow_logs to get_container_network_logs with fallback support for deprecated parameters |
| src/aks-preview/azext_aks_preview/custom.py | Adds new parameter definitions for container network logs in create and update functions |
| src/aks-preview/azext_aks_preview/_params.py | Registers new CLI parameters with deprecation warnings for old parameters |
| src/aks-preview/azext_aks_preview/_help.py | Updates help text to document new parameters and mark old ones as deprecated |
| src/aks-preview/HISTORY.rst | Documents the changes in the version history |
vakalapa
approved these changes
Oct 22, 2025
FumingZhang
reviewed
Oct 22, 2025
FumingZhang
previously approved these changes
Oct 27, 2025
yanzhudd
approved these changes
Oct 28, 2025
FumingZhang
pushed a commit
to FumingZhang/azure-cli-extensions
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retina-network-flow-logs is being renamed to container network logs.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.