[AKS] Support EntraID SSH #9329
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for EntraID SSH authentication in AKS by introducing a new entraid option for the --ssh-access parameter. This expands the existing SSH access modes (localuser and disabled) to include EntraID-based authentication.
Key Changes:
- Added
entraidas a new SSH access option alongside existinglocaluseranddisabledoptions - Comprehensive test coverage for EntraID SSH functionality including cluster creation, nodepool updates, and new nodepool addition
- Version bumped to 19.0.0b6
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bump from 19.0.0b5 to 19.0.0b6 |
| src/aks-preview/azext_aks_preview/_consts.py | Added CONST_SSH_ACCESS_ENTRAID constant |
| src/aks-preview/azext_aks_preview/_params.py | Imported and added entraid to ssh_accesses list |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added comprehensive test for EntraID SSH feature |
| src/aks-preview/HISTORY.rst | Added release notes for version 19.0.0b6 |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
Hi @norshtein Release SuggestionsModule: aks-preview
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='centraluseuap') | ||
| def test_aks_entraid_ssh(self, resource_group, resource_group_location): |
|
@FumingZhang I noticed the live test failed because the code change is not rolled out to selected region "westus2" yet. Could you help queue a test in canary regions? Thanks! |
|
I requeued on in centraluseuap and succeeded: https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=141435004&view=results |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.