Skip to content

Conversation

@nikitagarg123
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings October 24, 2025 12:52
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 24, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️redisenterprise
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd redisenterprise create cmd redisenterprise create added parameter public_network_access
⚠️ 1008 - ParaPropAdd redisenterprise database create cmd redisenterprise database create update parameter access_keys_authentication: added property aaz_default=Disabled
⚠️ 1008 - ParaPropAdd redisenterprise database create cmd redisenterprise database create update parameter access_keys_authentication: added property default=Disabled
⚠️ 1006 - ParaAdd redisenterprise update cmd redisenterprise update added parameter public_network_access

@azure-client-tools-bot-prd
Copy link

Hi @nikitagarg123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Redis Enterprise Azure CLI extension to use the new API version 2025-07-01, transitioning from the previous preview version (2025-05-01-preview and 2023-03-01-preview). The update includes adding support for the public_network_access parameter across cluster creation and update operations, updating the minimum Azure CLI core version requirement, changing the default value for access_keys_authentication from "Enabled" to "Disabled", and adding schema fields for error detail information.

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
azext_metadata.json Updated minimum Azure CLI core version from 2.70.0 to 2.75.0
custom.py Added public_network_access parameter to cluster creation function
_params.py Added public_network_access parameter definitions and updated access_keys_authentication help text
operation_status/_show.py Updated API version and added info field to error detail schema
database/access_policy_assignment/* Updated API version across all access policy assignment operations
database/* Updated API version across all database operations and added default value for access_keys_authentication
redisenterprise/* Updated API version and added public_network_access property to cluster schemas

options=["--identity-resource-id", "--user-assigned-identity-resource-id"],
arg_group="KeyEncryptionKeyIdentity",
help="User assigned identity to use for accessing key encryption key Url. Ex: `/subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId`.",
help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.",
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The help text still contains the literal string '' and '' which should be replaced with more standard placeholder syntax (e.g., '{subscription-id}' and '{resource-group}') for consistency with Azure documentation patterns.

Suggested change
help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.",
help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.",

Copilot uses AI. Check for mistakes.
c.argument('port', type=int, help='TCP port of the database endpoint. Specified at create time. Defaults to an '
'available port.')
c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is enabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.')
c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.')
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The help text states 'default is disabled', but this contradicts the behavior in database/_create.py where the default is explicitly set to 'Disabled' (line 97). While the code and documentation are technically aligned, the phrasing could be clearer - consider 'Defaults to Disabled' instead of 'default is disabled' for better readability.

Suggested change
c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.')
c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys. Defaults to Disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.')

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

Hi @nikitagarg123

Release Suggestions

Module: redisenterprise

  • Please log updates into to src/redisenterprise/HISTORY.rst
  • Update VERSION to 1.3.0 in src/redisenterprise/setup.py

Notes

If you want to release a new version for this extension, don't forget this @nikitagarg123

@nikitagarg123
Copy link
Member Author

Hi @nikitagarg123

Release Suggestions

Module: redisenterprise

  • Please log updates into to src/redisenterprise/HISTORY.rst
  • Update VERSION to 1.3.0 in src/redisenterprise/setup.py

Notes

If you want to release a new version for this extension, don't forget this @nikitagarg123

added this

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys evelyn-ys merged commit 14e7818 into Azure:main Oct 28, 2025
25 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ redisenterprise-1.3.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=141773456&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants