-
Couldn't load subscription status.
- Fork 1.5k
release redis enterprise api version 2025-07-01 #9332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release redis enterprise api version 2025-07-01 #9332
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| redisenterprise create | cmd redisenterprise create added parameter public_network_access |
||
| redisenterprise database create | cmd redisenterprise database create update parameter access_keys_authentication: added property aaz_default=Disabled |
||
| redisenterprise database create | cmd redisenterprise database create update parameter access_keys_authentication: added property default=Disabled |
||
| redisenterprise update | cmd redisenterprise update added parameter public_network_access |
|
Hi @nikitagarg123, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Redis Enterprise Azure CLI extension to use the new API version 2025-07-01, transitioning from the previous preview version (2025-05-01-preview and 2023-03-01-preview). The update includes adding support for the public_network_access parameter across cluster creation and update operations, updating the minimum Azure CLI core version requirement, changing the default value for access_keys_authentication from "Enabled" to "Disabled", and adding schema fields for error detail information.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| azext_metadata.json | Updated minimum Azure CLI core version from 2.70.0 to 2.75.0 |
| custom.py | Added public_network_access parameter to cluster creation function |
| _params.py | Added public_network_access parameter definitions and updated access_keys_authentication help text |
| operation_status/_show.py | Updated API version and added info field to error detail schema |
| database/access_policy_assignment/* | Updated API version across all access policy assignment operations |
| database/* | Updated API version across all database operations and added default value for access_keys_authentication |
| redisenterprise/* | Updated API version and added public_network_access property to cluster schemas |
| options=["--identity-resource-id", "--user-assigned-identity-resource-id"], | ||
| arg_group="KeyEncryptionKeyIdentity", | ||
| help="User assigned identity to use for accessing key encryption key Url. Ex: `/subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId`.", | ||
| help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.", |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The help text still contains the literal string '' and '' which should be replaced with more standard placeholder syntax (e.g., '{subscription-id}' and '{resource-group}') for consistency with Azure documentation patterns.
| help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/<sub uuid>/resourceGroups/<resource group>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.", | |
| help="User assigned identity to use for accessing key encryption key Url. Ex: /subscriptions/{subscription-id}/resourceGroups/{resource-group}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/myId.", |
| c.argument('port', type=int, help='TCP port of the database endpoint. Specified at create time. Defaults to an ' | ||
| 'available port.') | ||
| c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is enabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.') | ||
| c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.') |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The help text states 'default is disabled', but this contradicts the behavior in database/_create.py where the default is explicitly set to 'Disabled' (line 97). While the code and documentation are technically aligned, the phrasing could be clearer - consider 'Defaults to Disabled' instead of 'default is disabled' for better readability.
| c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys - default is disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.') | |
| c.argument('access_keys_authentication', options_list=['--access-keys-auth', '--access-keys-authentication'], arg_type=get_enum_type(['Enabled', 'Disabled']), help='Access database using keys. Defaults to Disabled. This property can be Enabled/Disabled to allow or deny access with the current access keys. Can be updated even after database is created.') |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
If you want to release a new version for this extension, don't forget this @nikitagarg123 |
added this |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ redisenterprise-1.3.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=141773456&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.