Skip to content

[AKS] Clarify aks update outbound type migration error for managed VNet clusters #33330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: dev
Choose a base branch
from
+28 −2
Draft

[AKS] Clarify aks update outbound type migration error for managed VNet clusters #33330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e0a4e
Initial plan
Copilot May 8, 2026
8484099
fix(aks): improve outbound type update error for managed vnet clusters
Copilot May 8, 2026
3638afd
chore(aks): refine outbound type update error string formatting
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2366,13 +2366,21 @@ def get_sku_name(self) -> str:
skuName = CONST_MANAGED_CLUSTER_SKU_NAME_BASE
return skuName

@staticmethod
def _raise_missing_vnet_subnet_for_outbound_type(outbound_type: str, sku_name: str) -> None:
def _raise_missing_vnet_subnet_for_outbound_type(self, outbound_type: str, sku_name: str) -> None:
if outbound_type == CONST_OUTBOUND_TYPE_USER_DEFINED_ROUTING:
subnet_requirement = "a route table with egress rules"
else:
subnet_requirement = "a NAT gateway with outbound ips"

if self.decorator_mode == DecoratorMode.UPDATE:
raise InvalidArgumentValueError(
f"Updating outbound type to {outbound_type} is only supported for clusters created with "
"--vnet-subnet-id. Clusters using an AKS-managed VNet can't be updated to this outbound type. "
"Please refer to "
"https://learn.microsoft.com/en-us/azure/aks/egress-outboundtype#updating-outboundtype-after-cluster-creation " # pylint:disable=line-too-long
"for more details."
)

if sku_name == CONST_MANAGED_CLUSTER_SKU_NAME_AUTOMATIC:
raise RequiredArgumentMissingError(
"--vnet-subnet-id must be specified for {outbound_type}. For an Automatic cluster "
Expand Down
18 changes: 18 additions & 0 deletions src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,6 +2020,24 @@ def test_get_outbound_type(self):
ctx_1.attach_mc(mc)
self.assertEqual(ctx_1.get_outbound_type(), "test_outbound_type")

ctx_1_1 = AKSManagedClusterContext(
self.cmd,
AKSManagedClusterParamDict(
{
"outbound_type": CONST_OUTBOUND_TYPE_USER_DEFINED_ROUTING,
}
),
self.models,
DecoratorMode.UPDATE,
)
ctx_1_1.agentpool_context = mock.MagicMock()
ctx_1_1.agentpool_context.get_vnet_subnet_id.return_value = None
with self.assertRaisesRegex(
InvalidArgumentValueError,
"only supported for clusters created with --vnet-subnet-id",
):
ctx_1_1.get_outbound_type()

# invalid parameter
ctx_2 = AKSManagedClusterContext(
self.cmd,
Expand Down