{CI} Fix all style errors for pylint 4.x compatibility#33347
Merged
Conversation
… duplicate functions, codecs.open migration)
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
YangAn-microsoft
requested review from
DanielMicrosoft,
Greedygre,
Juliehzl,
NoriZC,
ReaNAiveD,
VeryEarly,
calvinhzy,
howang-ms,
isra-fel,
necusjz,
teresaritorto and
yanzhudd
as code owners
…rning - Replace silent return statements with CLIError exceptions in apim_api_export - Raises CLIError when response link is missing (KeyError) - Raises CLIError when API export request returns non-OK status - Raises CLIError when API export request times out - This ensures proper error signaling in automation/CI pipelines (exit code non-zero on failure) - Addresses review feedback: guard clauses must not mask failures
…roper error handling
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/apim/custom.py:605
- In
apim_api_export, if the downloaded export payload is not valid JSON/YAML/XML, the nested parse attempts fall through after logging "Content is not in JSON, YAML, or XML format." without assigningexportedResultContent. The subsequent file-writing block then dereferencesexportedResultContent, which will raiseUnboundLocalErrorand hide the real payload/format issue. EnsureexportedResultContentis always assigned (e.g., default toexportedResults.text) or raise aCLIErrorwhen parsing fails so the command exits cleanly.
try:
# Try to parse as JSON
exportedResultContent = json.loads(exportedResults.text)
except json.JSONDecodeError:
try:
# Try to parse as YAML
exportedResultContent = yaml.safe_load(exportedResults.text)
except yaml.YAMLError:
try:
# Try to parse as XML
exportedResultContent = ET.fromstring(exportedResults.text)
except ET.ParseError:
logger.warning("Content is not in JSON, YAML, or XML format.")
necusjz
previously approved these changes
May 12, 2026
yanzhudd
previously approved these changes
May 13, 2026
bebound
reviewed
May 14, 2026
yanzhudd
approved these changes
May 14, 2026
necusjz
approved these changes
May 14, 2026
VeryEarly
approved these changes
May 14, 2026
calvinhzy
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Azure CLI code changes required to pass style checks with pylint 4.x.
What is included
Scope
Coordination