{Packaging} Bump paramiko upper limit to allow 5.x#33370
Conversation
Paramiko has made two modest breaking change releases. Neither should impact azure-cli. Before bumping the upper limit to 6.0, you may need to address the addition of a format keyword arg to `write_private_key_file()`[0], but in 5.0 the behavior remains the same as prior releases. [0] https://docs.paramiko.org/en/5.0/api/keys.html#paramiko.pkey.PKey.write_private_key_file
jeremycline
requested review from
DanielMicrosoft,
ReaNAiveD,
bebound,
jiasli,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure CLI Python package dependency constraints to permit installation with newer Paramiko releases (including 5.x), while still preventing upgrades to Paramiko 6.x.
Changes:
- Relax
paramikoupper bound ininstall_requiresfrom<4.0.0to<6.0.0to allow Paramiko 4.x/5.x.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Any specific reason for the bump? |
Most Linux distributions ship a single version of Paramiko. 5.0 has already landed in Fedora's rolling release, Rawhide, and as a result azure-cli stopped being installable. I've not checked on Debian, but I expect it is now, or soon will be, in a similar situation. Regularly testing and indicating support for newer versions of dependencies makes distribution maintainers jobs much less painful. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Paramiko has made two modest breaking change releases. Neither should impact azure-cli. Before bumping the upper limit to 6.0, you may need to address the addition of a format keyword arg to
write_private_key_file()[0], but in 5.0 the behavior remains the same as prior releases.[0] https://docs.paramiko.org/en/5.0/api/keys.html#paramiko.pkey.PKey.write_private_key_file
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.