[NetAppFiles] support 0.5 tib pool#33372
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR updates the az netappfiles pool create/update command surface to support the new 512 GiB (0.5 TiB) minimum capacity pool size, adds a --size-in-bytes option, and introduces tests/recordings to validate the new sizing rules and error behavior.
Changes:
- Added pool-size parsing/validation to accept
--sizeas TiB (float) down to0.5, or--size-in-bytesas bytes; the two are mutually exclusive. - Augmented service errors for sub-1 TiB pool sizing to include an AFEC feature-registration hint, plus scenario tests and recordings for the new behaviors.
- Updated generated AAZ files (notably
volume createdefault andaccount createexamples).
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/netappfiles/custom.py | Implements new --size/--size-in-bytes handling, validation, and AFEC hint augmentation for pool operations. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_pool_commands.py | Adds scenario tests for 0.5 TiB sizing, byte sizing, invalid values, and mutual exclusivity. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_pool_parameters.yaml | Updates recordings for existing pool parameter tests. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_get_pool_by_name.yaml | Updates recordings for existing pool show-by-name/id tests. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml | Updates recordings for existing invalid string --size test. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_minimum_size.yaml | Adds recording for --size 0.5 pool create behavior. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_size_in_bytes.yaml | Adds recording for --size-in-bytes 549755813888 pool create behavior. |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_invalid_size.yaml | Adds recording for rejecting invalid fractional TiB sizes (e.g., 1.5). |
| src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_mutually_exclusive_size.yaml | Adds recording for rejecting simultaneous --size and --size-in-bytes. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_create.py | Changes the default for --network-features from Basic to Standard. |
| src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_create.py | Updates command docstring examples for CMK + user-assigned identity usage across shells. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
az netappfiles
Description
Updates az netappfiles to support smaller capacity pool sizes.
Testing Guide
History Notes
[NetAppFiles]:
az netappfiles pool create:--sizenow accepts smaller size pools of value0.5to provision 512 GiB minimum pool size; otherwise it must be an integer multiple of 1 TiB.[NetAppFiles]:
az netappfiles pool update:--sizenow accepts smaller size pools of value0.5to provision 512 GiB minimum pool size; otherwise it must be an integer multiple of 1 TiB.[NetAppFiles]
az netappfiles pool create: Added new--size-in-bytesparameter accepting bytes directly (549755813888for 512 GiB or any positive multiple of1099511627776for 1 TiB).--sizeand--size-in-bytesare mutually exclusive.[NetAppFiles]
az netappfiles pool update: Added new--size-in-bytesparameter accepting bytes directly (549755813888for 512 GiB or any positive multiple of1099511627776for 1 TiB).--sizeand--size-in-bytesare mutually exclusive.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.