[ARM] az policy: Rewrite Azure Policy CRUD commands using auto-generation#33416
Open
Celinadhh wants to merge 25 commits into
Open
[ARM] az policy: Rewrite Azure Policy CRUD commands using auto-generation#33416Celinadhh wants to merge 25 commits into
az policy: Rewrite Azure Policy CRUD commands using auto-generation#33416Celinadhh wants to merge 25 commits into
Conversation
❌AzureCLI-FullTest
|
|
Hi @Celinadhh, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| policy assignment create | cmd policy assignment create added parameter self_serve_exemption_settings |
||
| policy assignment create | cmd policy assignment create update parameter enforcement_mode: updated property choices from ['Default', 'DoNotEnforce'] to ['Default', 'DoNotEnforce', 'Enroll'] |
||
| policy assignment create | cmd policy assignment create update parameter metadata: removed property nargs=+ |
||
| policy assignment create | cmd policy assignment create update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy assignment create | cmd policy assignment create update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy assignment update | cmd policy assignment update added parameter self_serve_exemption_settings |
||
| policy assignment update | cmd policy assignment update update parameter enforcement_mode: updated property choices from ['Default', 'DoNotEnforce'] to ['Default', 'DoNotEnforce', 'Enroll'] |
||
| policy assignment update | cmd policy assignment update update parameter metadata: removed property nargs=+ |
||
| policy assignment update | cmd policy assignment update update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy assignment update | cmd policy assignment update update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy definition create | cmd policy definition create added parameter external_evaluation_enforcement_settings |
||
| policy definition create | cmd policy definition create update parameter metadata: removed property nargs=+ |
||
| policy definition create | cmd policy definition create update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy definition create | cmd policy definition create update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy definition create | cmd policy definition create update parameter rules: removed property nargs=+ |
||
| policy definition create | cmd policy definition create update parameter rules: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy definition create | cmd policy definition create update parameter rules: updated property type from Dict<String,Any> to Any |
||
| policy definition update | cmd policy definition update added parameter external_evaluation_enforcement_settings |
||
| policy definition update | cmd policy definition update update parameter metadata: removed property nargs=+ |
||
| policy definition update | cmd policy definition update update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy definition update | cmd policy definition update update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy definition update | cmd policy definition update update parameter rules: removed property nargs=+ |
||
| policy definition update | cmd policy definition update update parameter rules: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy definition update | cmd policy definition update update parameter rules: updated property type from Dict<String,Any> to Any |
||
| policy definition version | sub group policy definition version added |
||
| policy enrollment | sub group policy enrollment added |
||
| policy exemption create | cmd policy exemption create update parameter exemption_category: removed property required=True |
||
| policy exemption create | cmd policy exemption create update parameter metadata: removed property nargs=+ |
||
| policy exemption create | cmd policy exemption create update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy exemption create | cmd policy exemption create update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy exemption create | cmd policy exemption create update parameter policy_assignment: removed property required=True |
||
| policy exemption update | cmd policy exemption update update parameter metadata: removed property nargs=+ |
||
| policy exemption update | cmd policy exemption update update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy exemption update | cmd policy exemption update update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy set-definition create | cmd policy set-definition create update parameter metadata: removed property nargs=+ |
||
| policy set-definition create | cmd policy set-definition create update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy set-definition create | cmd policy set-definition create update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy set-definition update | cmd policy set-definition update update parameter metadata: removed property nargs=+ |
||
| policy set-definition update | cmd policy set-definition update update parameter metadata: updated property aaz_type from AAZDictArg to AAZAnyTypeArg |
||
| policy set-definition update | cmd policy set-definition update update parameter metadata: updated property type from Dict<String,Any> to Any |
||
| policy set-definition version | sub group policy set-definition version added |
microsoft-github-policy-service
Bot
added
ARM
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Celinadhh
requested review from
MaddyMicrosoft,
isra-fel,
notyashhh,
teresaritorto and
xuming-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR rewrites Azure Policy CRUD command implementations to use the AAZ auto-generation toolset, onboarding to newer API versions and adding new command surfaces (definition/set-definition versions and policy enrollment).
Changes:
- Added new command groups and command registrations for policy definition version, policy set-definition version, and policy enrollment.
- Updated multiple policy command implementations to newer API versions and adjusted schemas (e.g., metadata/schema types, new properties like external evaluation settings and self-serve exemption).
- Refreshed test recordings to align with new API versions and client versions.
Reviewed changes
Copilot reviewed 63 out of 87 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/resource/tests/latest/recordings/test_resource_policy_arg_validate.yaml | Updates recording to newer API version/user-agent for policy definition calls. |
| src/azure-cli/azure/cli/command_modules/resource/commands.py | Registers new command groups for policy definition/set-definition versions and policy enrollment. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/version/_show.py | Adds generated “policy set-definition version show” command (new API version). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/version/_delete.py | Adds generated “policy set-definition version delete” command with confirmation. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/version/init.py | Exposes new policy set-definition version command modules. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/version/__cmd_group.py | Declares the “policy set-definition version” command group. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/_update.py | Moves set-definition update to newer API version and loosens metadata/schema typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/_show.py | Moves set-definition show to newer API version and loosens metadata/schema typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/_list.py | Moves set-definition list to newer API version and loosens metadata/schema typing; sets list value required. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/_delete.py | Moves set-definition delete to newer API version. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/set_definition/_create.py | Moves set-definition create to newer API version; adds example for version; loosens metadata/schema typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/exemption/_update.py | Updates exemption update to newer preview API; adds formats/enum values; loosens metadata typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/exemption/_show.py | Updates exemption show to newer preview API; loosens metadata typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/exemption/_list.py | Updates exemption list to newer preview API; adjusts arg formats; loosens metadata typing; sets list value required. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/exemption/_delete.py | Updates exemption delete to newer preview API. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/exemption/_create.py | Updates exemption create to newer preview API; loosens metadata typing; expands selector kind enum. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/_update.py | Adds generated “policy enrollment update” command (new preview API). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/_show.py | Adds generated “policy enrollment show” command (new preview API). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/_list.py | Adds generated “policy enrollment list” command (new preview API) with paging. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/_delete.py | Adds generated “policy enrollment delete” command with confirmation (new preview API). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/_create.py | Adds generated “policy enrollment create” command (new preview API). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/init.py | Exposes new policy enrollment command modules. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/enrollment/__cmd_group.py | Declares the “policy enrollment” command group. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/version/_show.py | Adds generated “policy definition version show” command (new API version). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/version/_delete.py | Adds generated “policy definition version delete” command with confirmation (new API version). |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/version/init.py | Exposes new policy definition version command modules. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/version/__cmd_group.py | Declares the “policy definition version” command group. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/_update.py | Moves policy definition update to newer API; adds external evaluation settings; loosens metadata/rule typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/_show.py | Moves policy definition show to newer API; includes external evaluation settings; loosens metadata/rule typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/_list.py | Moves policy definition list to newer API; includes external evaluation settings; sets list value required. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/_delete.py | Moves policy definition delete to newer API. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/definition/_create.py | Moves policy definition create to newer API; adds examples; adds external evaluation settings; loosens metadata/rule typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/_update.py | Moves non-compliance-message update to newer API; updates selector usage; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/_show.py | Moves non-compliance-message show to newer API; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/_list.py | Moves non-compliance-message list to newer API; updates selector usage; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/_delete.py | Moves non-compliance-message delete to newer API; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/_create.py | Moves non-compliance-message create to newer API; updates selector usage; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/non_compliance_message/__cmd_group.py | Updates non-compliance-message command group description. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/identity/_show.py | Moves assignment identity show to newer API; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/identity/_remove.py | Moves assignment identity remove to newer API; updates selector usage; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/identity/_assign.py | Moves assignment identity assign to newer API; updates selector usage; adds new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/identity/__cmd_group.py | Updates assignment identity command group description. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_update.py | Moves assignment update to newer API; adds new enforcement mode and self-serve exemption settings; loosens metadata typing. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_show.py | Moves assignment show to newer API; includes new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_list.py | Moves assignment list to newer API; includes new assignment properties in schema; sets list value required. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_delete.py | Moves assignment delete to newer API; includes new assignment properties in schema. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_create.py | Moves assignment create to newer API; adds enforcement mode and self-serve exemption settings; fixes docstring example. |
| src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/__cmd_group.py | Updates “policy” command group description to include policy enrollments. |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_create.py:1
- The help text says the possible values are only
DefaultandDoNotEnforce, but the enum now includesEnroll. Update thelong-summary(and/or short-summary) to includeEnrollso CLI help matches actual accepted values.
# --------------------------------------------------------------------------------------------
src/azure-cli/azure/cli/command_modules/resource/aaz/latest/policy/assignment/_update.py:1
- Same as create: help text omits
Enrolleven though it’s allowed by the enum. Adjust the help text so users discover the new value via-h.
# --------------------------------------------------------------------------------------------
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33416 in repo Azure/azure-cli |
mentat9
reviewed
Jun 4, 2026
mentat9
reviewed
Jun 4, 2026
added 23 commits
June 9, 2026 15:24
Member
Author
|
@Pan-Qi could you help me run /azp run again? thank you! |
Contributor
|
/azp run |
1 similar comment
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33416 in repo Azure/azure-cli |
Member
Author
|
@Pan-Qi somehow that didn't trigger the pipeline. could you try commenting again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az policy assignment {create, delete, list, show, update}
az policy assignment identity {assign, remove, show}
az policy assignment non-compliance-message {create, delete, list, show, update}
az policy definition {create, delete, list, show, update}
az policy definition version {create, delete, list, show, update}
az policy enrollment {create, delete, list, show, update}
az policy exemption {create, delete, list, show, update}
az policy set-definition {create, delete, list, show, update}
az policy set-definition version {create, delete, list, show, update}
Description
Reimplement all azure policy CRUD commands using the auto-generation toolset with customization. This will onboard CLI to the newer api-versions and to newer commands like definition/set-definition version and enrollment.
Testing Guide
All tests are updated and passing in record and playback modes.
Few new tests added.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.