Query: Adds LINQ extension method for ORDER BY RANK, FullTextScore and RRF #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kirankumarkolli merged 24 commits into master from users/leminh/FTRankLINQ

Apr 30, 2025

Contributor

leminh98 commented Feb 3, 2025

Pull Request Template

Description

This PR adds extension methods for ORDER BY RANK, FullTextScore, and RRF to the LINQ extension method support.

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Minh Le added 3 commits

February 3, 2025 04:27


          Function signature and basic test

739fd59


          Add construct for OrderByRank to the DOM


          update test

5a75674

leminh98 requested review from a team, khdang, sboshra, adityasa, neildsh, kirankumarkolli, FabianMeiswinkel and kirillg as code owners

February 3, 2025 15:29

leminh98 added the auto-merge label

microsoft-github-policy-service bot enabled auto-merge (squash)

February 3, 2025 15:30

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/SqlObjects/SqlOrderByRankClause.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/QueryUnderConstruction.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/OtherBuiltinSystemFunctions.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/OtherBuiltinSystemFunctions.cs Show resolved Hide resolved

Minh Le added 9 commits

March 6, 2025 16:23


          g4 file

bed61fa


          base grammar change

00bceb1


          update dom

5d9e380


          update baseline

1623b15


          merge with latest master

387490e


          merge with SQL DOM pr

6f78411


          merge w master


          update with DOM from master

781c102


          update baseline

420caef

Contributor

adityasa commented Apr 11, 2025 •

edited by leminh98

Loading

             && declaringType != typeof(CosmosLinqExtensions) /*OrderByRank*/)

Why is this check required, even though we had other functions in CosmosLinqExtensions before? #Resolved

Refers to: Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs:1164 in 09fe0f2. [](commit_id = 09fe0f2, deletion_comment = False)

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...rTests/BaselineTest/TestBaseline/LinqTranslationBaselineTests.TestRRFOrderByRankFunction.xml Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs Outdated Show resolved Hide resolved

adityasa reviewed

View reviewed changes

...Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTranslationBaselineTests.cs Outdated Show resolved Hide resolved

Contributor Author

leminh98 commented Apr 17, 2025

             && declaringType != typeof(CosmosLinqExtensions) /*OrderByRank*/)

the other extension type is all Enumerable, whereas the OrderByRank has a custom declration so we need to make an exception

In reply to: 2797948570

Refers to: Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs:1164 in 09fe0f2. [](commit_id = 09fe0f2, deletion_comment = False)

Minh Le added 7 commits

April 18, 2025 13:45


          update RRF interface

8fd19de


          Changes to unit test

bfb5912


          fix composition bug

8c3c0e7


          Merge branch 'master' into users/leminh/FTRankLINQ

5136b6c


          fix typo

22fc735


          Update with latest master and new test suite

f8c7760


          update ftscore to use params

2b081f9

adityasa previously approved these changes

View reviewed changes

Contributor

adityasa left a comment


          update line ending

d68fc4d

leminh98 dismissed adityasa’s stale review via

d68fc4d

April 29, 2025 19:04


          Merge branch 'master' into users/leminh/FTRankLINQ

679844e

kirankumarkolli reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/BuiltinFunctionVisitor.cs Show resolved Hide resolved

kirankumarkolli previously approved these changes

View reviewed changes


          Update error message for OrderByRank

69ebfae

adityasa previously approved these changes

View reviewed changes

Contributor

adityasa left a comment


          Merge branch 'users/leminh/FTRankLINQ' of https://github.com/Azure/az…

687f0f5

…ure-cosmos-dotnet-v3 into users/leminh/FTRankLINQ

leminh98 dismissed stale reviews from adityasa and kirankumarkolli via

687f0f5

April 29, 2025 19:38

adityasa approved these changes

View reviewed changes

Contributor

adityasa left a comment

Maya-Painter approved these changes

View reviewed changes

kirankumarkolli disabled auto-merge

April 30, 2025 18:43

kirankumarkolli merged commit 7711480 into master

26 checks passed

kirankumarkolli deleted the users/leminh/FTRankLINQ branch

April 30, 2025 18:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adityasa adityasa approved these changes

Maya-Painter Maya-Painter approved these changes

kirankumarkolli kirankumarkolli left review comments

khdang Awaiting requested review from khdang khdang is a code owner

sboshra Awaiting requested review from sboshra sboshra is a code owner

neildsh Awaiting requested review from neildsh neildsh is a code owner

FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

kirillg Awaiting requested review from kirillg kirillg is a code owner

Labels