Query: Adds LINQ extension method for ORDER BY RANK, FullTextScore and RRF #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leminh98
requested review from
a team,
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
adityasa
reviewed
Feb 18, 2025
| /// </example> | ||
| public static Func<TSource, object> FullTextScore<TSource>(this TSource obj, string[] terms) | ||
| { | ||
| throw new NotImplementedException(ClientResources.TypeCheckExtensionFunctionsNotImplemented); //Todo: change this to LINQNotImplemented once the FTContains PR is checked in |
adityasa
reviewed
Feb 18, 2025
| /// </example> | ||
| public static Func<TSource, object> RRF<TSource>(this object obj, params Func<TSource, object>[] scoringFunctions) | ||
| { | ||
| throw new NotImplementedException(ClientResources.TypeCheckExtensionFunctionsNotImplemented); //Todo: change this to LINQNotImplemented once the FTContains PR is checked in |
adityasa
reviewed
Feb 18, 2025
| @@ -1159,8 +1159,9 @@ private static Collection VisitMethodCall(MethodCallExpression inputExpression, | |||
| context.PushMethod(inputExpression); | |||
|
|
|||
| Type declaringType = inputExpression.Method.DeclaringType; | |||
| if ((declaringType != typeof(Queryable) && declaringType != typeof(Enumerable)) | |||
| || !inputExpression.Method.IsStatic) | |||
| if ((declaringType != typeof(Queryable) && declaringType != typeof(Enumerable) /*LINQ Methods*/ | |||
adityasa
reviewed
Feb 18, 2025
| if ((declaringType != typeof(Queryable) && declaringType != typeof(Enumerable)) | ||
| || !inputExpression.Method.IsStatic) | ||
| if ((declaringType != typeof(Queryable) && declaringType != typeof(Enumerable) /*LINQ Methods*/ | ||
| && declaringType != typeof(CosmosLinqExtensions) /*OrderByRank*/) |
adityasa
reviewed
Feb 18, 2025
| #else | ||
| internal | ||
| #endif | ||
| sealed class SqlOrderByRankClause : SqlObject |
There was a problem hiding this comment.
If this class needs to stay (let's discuss if that's the case since it's not desirable to introduce another type for this small a change in the model), there should be a common base class between SqlOrderByClause and SqlOrderByRankClause.
There was a problem hiding this comment.
I think it makes sense to have parity with the BE. Let me check how the DOM is there and i will reflect it in this change
adityasa
reviewed
Feb 18, 2025
| @@ -59,14 +59,15 @@ public ParameterExpression Alias | |||
|
|
|||
| private SqlSelectClause selectClause; | |||
| private SqlWhereClause whereClause; | |||
| private SqlOrderByClause orderByClause; | |||
| private SqlOrderByClause orderByClause; | |||
| private SqlOrderByRankClause orderbyRankClause; | |||
There was a problem hiding this comment.
Given that these are mutually exclusive, we should have a single type SqlOrderByClause representing both.
adityasa
reviewed
Feb 18, 2025
| //protected override SqlScalarExpression VisitExplicit(MethodCallExpression methodCallExpression, TranslationContext context) | ||
| //{ | ||
| // return null; | ||
| //} |
There was a problem hiding this comment.
Please remove if not needed.
adityasa
reviewed
Feb 18, 2025
Microsoft.Azure.Cosmos/src/Linq/BuiltinFunctions/OtherBuiltinSystemFunctions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds extension methods for ORDER BY RANK, FullTextScore, and RRF to the LINQ extension method support.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber