Powershell Changes For EntraID support for DataSync#29383
Powershell Changes For EntraID support for DataSync#29383ssubramanya wants to merge 5 commits intoAzure:mainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution @ssubramanya! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree company="Microsoft" |
@microsoft-github-policy-service agree company="Microsoft" |
|
Azure Pipelines: 4 pipeline(s) require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
LGTM |
Head branch was pushed to by a user without write access
97028e4 to
e84d23c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
… CloudException catch in NewAzureSqlSyncAgent
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
gouravsharmamicrosoft
left a comment
There was a problem hiding this comment.
This is a copy of old PR which was reviewed and approved
hareeshghk
left a comment
There was a problem hiding this comment.
Overall looks good, added two comments
| /// Gets or sets the identity ID of the hub database in case of user assigned identity authentication | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, HelpMessage = "The resource ID of the UAMI (User Assigned Managed Identity) to use for hub database authentication.")] | ||
| public string ResourceId { get; set; } |
There was a problem hiding this comment.
here its written as resource id and also in tests but PT description says IdentityId, can you update one.
Also have you tested with latest changes of DsMainDev as few changes and new validations went into DsMainDev after your previous powershell testing
| /// </summary> | ||
| [Parameter(Mandatory = false, HelpMessage = "The resource ID of the User Assigned Managed Identity (UAMI) to remove from hub database authentication." + | ||
| "If specified, this UAMI will be removed ")] | ||
| public string RemoveIdentityResourceId { get; set; } |
There was a problem hiding this comment.
This about user experience, is it better to add an extra parameter like this or we only get the syncgroup and member first to receive resourceid and add a confirmation saying that "adding new UAMI will remove existing one" , just as a suggetsions, this also looks good
Description
Note:
This is the same PR as
https://github.com/Azure/azure-powershell/pull/28464with Newer SDK used from latest swagger (after 2025-02-01-preview changes)This is a Private Preview Feature from DataSync Point of view and Public Preview feature from Azure powershell Point of view and is being targeted to May 5th Release of powershell.
The design doc for the same can be found here
https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev/pullrequest/1801408?path=/Sql/xdb/manifest/svc/DataSync/synclibs/ClientSetup/LocalAgentSetup.wixproj&_a=files
Summary of Changes
Added UAMI Support
New-*andUpdate-*cmdlets:HubDatabaseAuthenticationTypeMemberDatabaseAuthenticationTypeIdentityIdThese parameters allow customers to:
PasswordorUserAssigned)Backward Compatibility
Validation Logic
UsernameandPassword.IdentityIdwhen creating new resources.UserAssignedis specified withoutIdentityId, cmdlet preserves the existing identity instead of throwing.Help and Documentation
Password,UserAssigned)Resource Strings
IdentityIdTesting
https://microsoftapc-my.sharepoint.com/personal/subramanyamn_microsoft_com/_layouts/15/Doc.aspx?sourcedoc=%7B97ff60bb-4654-4fcb-bd0f-5afae5c3643b%7D&action=edit&wd=target%28Powershell%20Testing.one%7C311638eb-0c66-44ba-8585-4c95e79fc90b%2FPowershell%20Testing%7Cfea2d48f-27c3-4c2c-8c1d-aea2635506d0%2F%29&wdorigin=703&wdpartid=%7B4fdb5b93-9fe6-4b01-971f-f2a8830f51ac%7D%7B21%7D&wdsectionfileid=%7B93351f16-fc84-4b29-98bd-994ed3d9584b%7D
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.