Skip to content

Release search azure.search preview/2025-05-01-preview bug fix #34422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xiong-qiao
Copy link
Contributor

@xiong-qiao xiong-qiao commented May 2, 2025

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Release planner

A release plan should have been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@xiong-qiao xiong-qiao requested review from arv100kri, bleroy, BevLoh, giulianob and a team as code owners May 2, 2025 19:59
Copy link

openapi-pipeline-app bot commented May 2, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 2, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label May 2, 2025
Copy link

github-actions bot commented May 2, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Azure.Search-Azure.Search

Copy link
Member

@arv100kri arv100kri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffreyRichter JeffreyRichter added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label May 2, 2025
@xiong-qiao xiong-qiao added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label May 5, 2025
@xiong-qiao xiong-qiao enabled auto-merge (squash) May 5, 2025 20:40
@xiong-qiao xiong-qiao disabled auto-merge May 6, 2025 15:10
@xiong-qiao xiong-qiao merged commit 1755004 into main May 6, 2025
47 of 50 checks passed
@xiong-qiao xiong-qiao deleted the xqiao/release-search-Azure.Search-preview/2025-05-01-preview-bug-fix branch May 6, 2025 21:48
koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
johnkoh-msft pushed a commit to johnkoh-msft/azure-rest-api-specs that referenced this pull request May 8, 2025
johnkoh-msft added a commit that referenced this pull request May 12, 2025
…04 11 preview (#34389)

* Copy files from preview/2025-03-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-04-11-preview

Updated the API version from preview/2025-03-01-preview to preview/2025-04-11-preview.

* Added tag for 2025-04-11-preview in readme file

* Fix namespace

* Fix validation errors

* Fix validation errors again

* Change type of body schema

* Fix example

* Updated the apiFlowOptions field

* Add None

* Remove None

* Add ForceDisable Pipeline enum

* Add PipelineForceDisabled status

* Bump @azure-tools/typespec-client-generator-cli (#34410)

Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.20.0 to 0.21.0
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-version: 0.21.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* adding options for csharp generator (#34413)

Co-authored-by: deepakmaurya_microsoft <[email protected]>

* Add new APC API version (#33625)

* Add new version
* Typespec v1.0.0 and add .NET SDK generation options

* Adding options for C# generator for MongoDB.Atlas (#34415)

* adding options for c# generator

* updating tspconfig.yaml

* Bump vite from 6.3.3 to 6.3.4 in /.github (#34412)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.3 to 6.3.4.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.4/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Sync eng/common directory with azure-sdk-tools for PR 10523 (#34418)

* fix: bump node version in emitter pipeline

* pr feedback

---------

Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>

* [LintDiff] Improve logging output (#34398)

* Improve logging output

* Adjust logging

* Trivial change to trigger LintDiff

* Breaking change that causes LintDiff to fail

* Always include link in the log

* Try to break URL

* generate autorest exception

* Add source to table

* Contrive an error that will fail LintDiff

* Regular LintDiff failure

* Contrive autorest error

* Log violations

* -table

* Logging inside lint-diff.ts instead of lintdiff.yaml

* +list

* log GITHUB_SERVER_URL

* log more

* console.log

* Revert contosowidgetmanager

* Exit if there's nothing to do

* Test successful LintDiff run

* Revert "Test successful LintDiff run"

This reverts commit 6d7bd0a.

* Log link to workflow summary on success, too

* Reverted apiview enablement due to a bug (#34417)

* [shared] Add SpecModel (#33362)

- Fixes #33227

* [spec-model] One file per class, add tests for 100% coverage (#34431)

* [spec-model] Remove sync access check from ctors (#34432)

- Improves perf and testability

* [spec-model] Move specModel to options (#34433)

- Only needed for relative paths in toJsonAsync()

* Add None

* Remove None

* Add ForceDisable Pipeline enum

* [LintDiff, Avocado] Extract label-override code (#34445)

* Generalize avocado-status.js, wire up lintdiff-status.yaml

* Testing, lintdiff.yaml -> lintdiff-code.yaml

* Now with types

* prettier

* Use reusable workflow

* Param names, copy

* Revert label.js changes, they're not needed in this PR

* Set Status

* Prettier

* CQA build api changes (#34299)

* CQA build api changes

* adding swagger references in readme

* Adding initial examples for the new api version

* adding examples for new changes

* fixing build failures

* updating tsp examples

* whitespace error

* Spell checks

---------

Co-authored-by: Yash Oswal <[email protected]>
Co-authored-by: Bidisha Chakraborty <[email protected]>

* Update client settings for releasing Workload .Net SDK (#34461)

* [recoveryservicesdatareplication] update tsp config (#34360)

* Update client.tsp

* format

* remove the duplicate models for projects, branches, database, roles a… (#34283)

* remove the duplicate models for projects, branches, database, roles and endpoints in the main.tsp

* updated examples using oav generate examples command

* updated the examples to fix the model and semantic validations

* fix typespec errors

* addressed comments changed the namespace to neon.postgres

* fix typespec issue

* update the spec by removing the unused api

* updated the typespec by removing the out of scope items

---------

Co-authored-by: Srinivas Alluri <[email protected]>

* Add package to validate TypeSpec migration result (#34438)

* Add package to validate typespec migration

* Some fix

* Add prompt support

* update

* Update

---------

Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 10534 (#34455)

* Add helper function for spec-gen-sdk pipeline

* Move logging script sourceing to global scope

---------

Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>

* Add spilloverDeploymentName (#34376)

* Sync eng/common directory with azure-sdk-tools for PR 10542 (#34454)

* update most current taxnonomy for entra

* update link

---------

Co-authored-by: Minh Anh <[email protected]>

* Add Relationships RP Public Preview Spec Files (#33932)

* add initial Relationships RP files

* make provisioningState readOnly

* update readme, remove readmes and edit confiig

* [spec-model] Add option to create Readme from string content (#34465)

* Fix two bugs for grounding api and acl (#34422)

* [eng/tools] Upgrade target and module to match TypeSpec repo (#34480)

- Required to use APIs like string.replaceAll()

* ACR: Update 2025-04-01 GA Swagger to fix SDK generation failure (#34233)

* ACR: Update 2025-04-01 GA Swagger to fix SDK generation failure

* add lintdiff suppression for connected registry update parameters

* fix suppression parameter reference

* address review comments

* deploy the proxy with human-readable multipart output (#34409)

Co-authored-by: Scott Beddall <[email protected]>

* [dellstorage] update-tspconfig (#34459)

* update-tspconfig

* Update tspconfig.yaml

* java config

* update config

---------

Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: XiaofeiCao <[email protected]>
Co-authored-by: jliusan <[email protected]>

* java, mgmt, Azure Chaos Studios, client (#34466)

* fist, mgmt, client.tsp, add flattenProperty for backward-compatibility (#34204)

* Adding 2025-03-01-preview api version (#33924)

* Adding 2025-03-01-preview api version

* Fixing format

* Fixing validation errors

* Fixing format

* Adding versioning

* Suppressing lintdiff errors

* Removing sdk generation config from readme

* Adding output-dir to tsp files

* Adding where clause for suppression rules

* Incorporating review comments

* Correcting format

* Updating suppression where clause

* Refactoring to fix lintdiff

* Correcting typo to fix lintdiff

---------

Co-authored-by: Yuchao Yan <[email protected]>

* fix go config (#34487)

* java, mgmt, chaos, update client.tsp (#34488)

* add go config (#34485)

* Retirement announcement (#34353)

Co-authored-by: Faraz Siddiqui <[email protected]>

* [LintDiff] Use spec model (#34463)

* Tell typescript to use ESNext to eliminate errors on private class members

* Use spec model

* Update package-lock.json

* Contrive a change to test LintDiff

* Remove deep-eql, use bundle and JSON.stringify instead, add test coverage

* Use deref

* Remove fs mock

* Revert change that triggers LintDiff

* Remove ESNext from .github/shared/tsconfig.json

* Remove target/module definitoins from lint-diff/tsconfig.json

* newlines

* newline

* Update watchers to watch new workflow names (#34501)

* Upgrade typespec 1.0 (#34482)

* [LintDiff] Only process existing files (#34504)

* Only process existing files

* Add test coverage

* Skip resolving examples

* Test fixtures

* newline

* Remove extra logging

* Prettier

* Update error message

* Prettier

* isWindows()

* Revert changes to .github

* Remvoe references to examples (files not present, not needed)

* Update sample tspconfig.yaml in Contoso.Management (#34114)

* [sitemanager] update tsp config (#34495)

* Create client.tsp

* reformat

* reformat

* Update client settings for releasing CarbonEmission.Net SDK (#34497)

* java, mgmt, Azure Arc site manager, client (#34527)

* Sdk config change (#34526)

* sdk config change

* typespec failures

* typespec failures

---------

Co-authored-by: deepakmaurya_microsoft <[email protected]>

* java, mgmt, MongoDB Atlas, client (#34467)

* Add PipelineForceDisabled status

* Remove PipelineForceDisabled status

* Remove ForceDisable

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Steven Kim <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: deepakmauryams <[email protected]>
Co-authored-by: deepakmaurya_microsoft <[email protected]>
Co-authored-by: SallyAnneBennett <[email protected]>
Co-authored-by: Ajay Kumar <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: yashoswal <[email protected]>
Co-authored-by: Yash Oswal <[email protected]>
Co-authored-by: Bidisha Chakraborty <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: Srinivas <[email protected]>
Co-authored-by: Srinivas Alluri <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: ZhidaLiu <[email protected]>
Co-authored-by: Minh Anh <[email protected]>
Co-authored-by: Alex Chrostowski <[email protected]>
Co-authored-by: Xiong Qiao <[email protected]>
Co-authored-by: savaradh <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: XiaofeiCao <[email protected]>
Co-authored-by: jliusan <[email protected]>
Co-authored-by: Hong Li(MSFT) <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: bsomeshekar <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: steve munk <[email protected]>
Co-authored-by: Faraz Siddiqui <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. Search Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants