-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Microsoft.ResourceNotifications - Adding new resource type and APIs(ResourceSubscription, Destinations) #38719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Priyanarang
wants to merge
21
commits into
main
Choose a base branch
from
prnaran/subscriberAPI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive TypeSpec-based API specification for Microsoft.ResourceNotifications - Implement ResourceSubscription resource with tenant/cloud scope support - Add Destination extension resource with fabric table and storage account types - Support discriminated unions for polymorphic properties (scope, partitioning, destinations) - Include ARN location partitioning configuration with partition definitions - Add path policies for time and scope range hash-based routing - Support batching policies with minimum count and maximum delay configuration - Provide complete CRUD operations for both resources with ARM compliance - Include comprehensive example files for all API operations - Generate ARM-compliant OpenAPI specification with proper pagination support - Support multi-language SDK generation (C#, Python, Java, JavaScript, Go) - API version: 2025-11-11-preview
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
…and correct parameter names
…iminator properties
272b429 to
47bd36b
Compare
- Updated tspconfig.yaml to use {output-dir} pattern for SDK emitters following Azure SDK conventions
- Removed project-root parameter definition as it's built-in to TypeSpec
- Regenerated OpenAPI spec with omit-unreachable-types option enabled
- Configures AutoRest settings for Resource Notifications ARM service - Specifies package-preview-2025-11 tag with correct input file path - Follows Azure ARM service documentation standards
- Updated input-file path to point to correct location in resource-manager folder - Resolves CI/CD pipeline error looking for OpenAPI spec in wrong directory
- Separated DestinationPatchProperties from discriminated union to avoid inheriting required discriminator - PATCH operations should not have required properties for partial updates - Resolves PatchBodyParametersSchema validation error
- Removed ResourceSubscriptionPatch and DestinationPatch models - Changed update operations to use ArmResourceCreateOrUpdateAsync (PUT) - Eliminated PATCH validation issues with discriminated unions - Follows Azure ARM best practices for resource management - TypeSpec compilation automatically removed PATCH examples and updated OpenAPI spec
- Deleted ResourceSubscriptions_Update.json - Deleted ResourceSubscriptionDestinations_Update.json - Management and resource-manager example folders now consistent - No more PATCH operation examples anywhere
…equirements - Added ResourceSubscriptionPatch model for updates - Added ResourceSubscriptionPatchProperties for property updates - Added update operation using ArmResourcePatchSync - Resolves ARM compliance error requiring TrackedResource PATCH operations
- Added ResourceSubscriptions_Update.json example file - Added x-ms-examples extension to update operation in TypeSpec - Fixed example schema to match discriminated union requirements - Resolves XMS_EXAMPLE_NOTFOUND_ERROR validation error
…ns from update operations - Created ResourceSubscriptionUpdateProperties with only query property - Used ArmCustomPatchSync with ResourceUpdateModel for proper PATCH semantics - Removed ScopeUpdate, PartitioningConfigurationUpdate auto-generated models - Resolves PatchBodyParametersSchema validation error requiring optional properties - Updated example to only include simple query update
- Fixed code style issues in example file - Applied proper JSON formatting
- Updated title and description for proper resource provider identification - Removed openapi-subtype that might be causing PowerShell script issues - Ensured standard ARM readme.md format for APIView token generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
CI-NewRPNamespaceWithoutRPaaS
new-api-version
new-rp-namespace
NotReadyForARMReview
resource-manager
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.