Skip to content

Conversation

@Priyanarang
Copy link
Member

  • Add comprehensive TypeSpec-based API specification for Microsoft.ResourceNotifications
  • Implement ResourceSubscription resource with tenant/cloud scope support
  • Add Destination extension resource with fabric table and storage account types
  • Support discriminated unions for polymorphic properties (scope, partitioning, destinations)
  • Include ARN location partitioning configuration with partition definitions
  • Add path policies for time and scope range hash-based routing
  • Support batching policies with minimum count and maximum delay configuration
  • Provide complete CRUD operations for both resources with ARM compliance
  • Include comprehensive example files for all API operations
  • Generate ARM-compliant OpenAPI specification with proper pagination support
  • Support multi-language SDK generation (C#, Python, Java, JavaScript, Go)
  • API version: 2025-11-11-preview

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Priya Narang and others added 2 commits November 11, 2025 15:02
- Add comprehensive TypeSpec-based API specification for Microsoft.ResourceNotifications
- Implement ResourceSubscription resource with tenant/cloud scope support
- Add Destination extension resource with fabric table and storage account types
- Support discriminated unions for polymorphic properties (scope, partitioning, destinations)
- Include ARN location partitioning configuration with partition definitions
- Add path policies for time and scope range hash-based routing
- Support batching policies with minimum count and maximum delay configuration
- Provide complete CRUD operations for both resources with ARM compliance
- Include comprehensive example files for all API operations
- Generate ARM-compliant OpenAPI specification with proper pagination support
- Support multi-language SDK generation (C#, Python, Java, JavaScript, Go)
- API version: 2025-11-11-preview
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the CI-NewRPNamespaceWithoutRPaaS label.
  • ❌ This PR has CI-NewRPNamespaceWithoutRPaaS label. This means it is introducing a new RP (Resource Provider) namespace that has not been onboarded with RPaaS. Merging this PR to the main branch is blocked as RPaaS is required for new RPs.
    To resolve, use RPaaS to onboard the new RP. To apply for exception, see aka.ms/RPaaSException.


Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.ResourceNotifications
Python azure-mgmt-resourcenotifications
C# Azure.ResourceManager.ResourceNotifications
JavaScript @azure/arm-resourcenotifications
Java com.azure.resourcemanager:azure-resourcemanager-resourcenotifications
Go sdk/resourcemanager/resourcenotifications/armresourcenotifications

@Priyanarang Priyanarang force-pushed the prnaran/subscriberAPI branch from 272b429 to 47bd36b Compare November 11, 2025 23:29
Priya Narang added 7 commits November 11, 2025 16:09
- Updated tspconfig.yaml to use {output-dir} pattern for SDK emitters following Azure SDK conventions
- Removed project-root parameter definition as it's built-in to TypeSpec
- Regenerated OpenAPI spec with omit-unreachable-types option enabled
- Configures AutoRest settings for Resource Notifications ARM service
- Specifies package-preview-2025-11 tag with correct input file path
- Follows Azure ARM service documentation standards
Priya Narang added 9 commits November 11, 2025 16:39
- Updated input-file path to point to correct location in resource-manager folder
- Resolves CI/CD pipeline error looking for OpenAPI spec in wrong directory
- Separated DestinationPatchProperties from discriminated union to avoid inheriting required discriminator
- PATCH operations should not have required properties for partial updates
- Resolves PatchBodyParametersSchema validation error
- Removed ResourceSubscriptionPatch and DestinationPatch models
- Changed update operations to use ArmResourceCreateOrUpdateAsync (PUT)
- Eliminated PATCH validation issues with discriminated unions
- Follows Azure ARM best practices for resource management
- TypeSpec compilation automatically removed PATCH examples and updated OpenAPI spec
- Deleted ResourceSubscriptions_Update.json
- Deleted ResourceSubscriptionDestinations_Update.json
- Management and resource-manager example folders now consistent
- No more PATCH operation examples anywhere
…equirements

- Added ResourceSubscriptionPatch model for updates
- Added ResourceSubscriptionPatchProperties for property updates
- Added update operation using ArmResourcePatchSync
- Resolves ARM compliance error requiring TrackedResource PATCH operations
- Added ResourceSubscriptions_Update.json example file
- Added x-ms-examples extension to update operation in TypeSpec
- Fixed example schema to match discriminated union requirements
- Resolves XMS_EXAMPLE_NOTFOUND_ERROR validation error
…ns from update operations

- Created ResourceSubscriptionUpdateProperties with only query property
- Used ArmCustomPatchSync with ResourceUpdateModel for proper PATCH semantics
- Removed ScopeUpdate, PartitioningConfigurationUpdate auto-generated models
- Resolves PatchBodyParametersSchema validation error requiring optional properties
- Updated example to only include simple query update
- Fixed code style issues in example file
- Applied proper JSON formatting
- Updated title and description for proper resource provider identification
- Removed openapi-subtype that might be causing PowerShell script issues
- Ensured standard ARM readme.md format for APIView token generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants