Skip to content

Conversation

@anushkasingh16
Copy link

SDK configuration pull request

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Nov 11, 2025
@anushkasingh16 anushkasingh16 force-pushed the anushkasingh/fix-mtc-definition branch from f75a0b8 to a4003c2 Compare November 11, 2025 23:34
@anushkasingh16 anushkasingh16 changed the title Anushkasingh/fix mtc definition Adding more context to maintenance configuration description Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/containerservice/armcontainerservice
Java com.azure.resourcemanager:azure-resourcemanager-containerserviceaks-generated
JavaScript @azure/arm-containerservice
Python azure-mgmt-containerservice

@anushkasingh16 anushkasingh16 marked this pull request as ready for review November 12, 2025 20:36
"required": true,
"type": "string",
"description": "The name of the maintenance configuration."
"description": "The name of the maintenance configuration. Supported values are 'default', 'aksManagedAutoUpgradeSchedule', or 'aksManagedNodeOSUpgradeSchedule'."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please fix failed Swagger PrettierCheck
  2. Please make changes only to specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-10-02-preview/managedClusters.json in this PR. You can update the stable API (and it should be 2025-10-01, instead of 2025-09-01) in the dev-containerservice-Microsoft.ContainerService-2025-10-01 branch.

@anushkasingh16 anushkasingh16 force-pushed the anushkasingh/fix-mtc-definition branch from 2ab1abe to a4003c2 Compare November 14, 2025 01:57
@anushkasingh16 anushkasingh16 changed the title Adding more context to maintenance configuration description Adding more context to maintenance configuration description for Microsoft.ContainerService-2025-10-02-preview Nov 14, 2025
@FumingZhang FumingZhang merged commit 6c2435f into Azure:FumingZhang-containerservice-Microsoft.ContainerService-2025-10-02-preview Nov 14, 2025
84 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Container Service resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants