Skip to content

[Ddos] Add ILPIP DCP in 2025-07-01 TypeSpec/Swagger#42075

Open
venkatasaimaram7 wants to merge 5 commits intoAzure:release-microsoft-network-2025-07-01from
venkatasaimaram7:venm/ilpip-typespec-dcp
Open

[Ddos] Add ILPIP DCP in 2025-07-01 TypeSpec/Swagger#42075
venkatasaimaram7 wants to merge 5 commits intoAzure:release-microsoft-network-2025-07-01from
venkatasaimaram7:venm/ilpip-typespec-dcp

Conversation

@venkatasaimaram7
Copy link
Copy Markdown

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Use this filled version for your PR body (copy-paste):

Purpose of this PR

  • New resource provider.
  • New API version for an existing resource provider.
  • Update existing version for a new feature.
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec.
  • Other, please clarify:
    • Add ILPIP DCP contract support in 2025-07-01 by adding ddosCustomPolicy under DdosSettings in TypeSpec and regenerating corresponding swagger.

Due diligence checklist

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed Resource Provider guidelines, ARM resource provider contract, and REST guidelines.
  • A release plan has been created. (Will be created/linked if required by review workflow.)

Additional information

Scope

  • 2025-07-01 only.

Files changed

  • main.tsp
  • virtualNetwork.json

Summary of change

  • Added ddosCustomPolicy to DdosSettings so ILPIP/Public IP DDoS settings can reference a DDoS custom policy (DCP).

Notes

  • Generated swagger from TypeSpec.
  • No internal runtime-only fields (GUID/SLB region tracking) were added to external API contract.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 2, 2026
@GiriB
Copy link
Copy Markdown
Member

GiriB commented Apr 2, 2026

Do we need any change on DdosCustomPolicy resource as well? How does PIP show up on DCP resource?

@ravimeda
Copy link
Copy Markdown
Member

ravimeda commented Apr 3, 2026

Please address the failure in 'Sagger Avocado' check

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 3, 2026
Venkata M added 4 commits April 2, 2026 18:25
- Move #suppress decorators before @visibility decorators
- Fixes TypeSpec format validation (tsp format --check)
- Both properties have camelCase naming from REST spec, suppress documents this
@venkatasaimaram7 venkatasaimaram7 force-pushed the venm/ilpip-typespec-dcp branch from beddf3a to db71fda Compare April 4, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants