Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Hubs: Expose Offset as a String and add Geo-DR capability #44272

Merged
merged 22 commits into from
Feb 21, 2025
Merged

Event Hubs: Expose Offset as a String and add Geo-DR capability #44272

merged 22 commits into from
Feb 21, 2025

Conversation

conniey
Copy link
Member

@conniey conniey commented Feb 19, 2025 •
edited
Loading

Description

  • Exposes offset as a String (.getOffsetString()). Deprecates getOffset()
  • Adds geo-dr capability to receive link.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

conniey added 17 commits February 18, 2025 12:30
@conniey
Copy link
Member Author

conniey commented Feb 19, 2025

/azp run java - eventhubs - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 19, 2025 •
edited
Loading

API change check

API changes are not detected in this pull request.

anuchandy
anuchandy approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Connie!

@conniey conniey changed the base branch from main to eventhubs/feature/geo-dr February 20, 2025 23:24
@conniey
Copy link
Member Author

conniey commented Feb 20, 2025

/azp run java - eventhubs - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Feb 21, 2025

/azp run java - eventhubs - tests

@conniey conniey merged commit cf5c5c6 into Azure:eventhubs/feature/geo-dr Feb 21, 2025
11 of 12 checks passed
@conniey conniey deleted the eventhubs/geodrv2 branch February 21, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conniey @azure-sdk @anuchandy