clientcore, fix handle of Base64Uri in RestProxy parameter #44287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
weidongxu-microsoft
requested review from
samvaity,
vcolin7,
JonathanGiles,
srnagar and
alzimmermsft
as code owners
| @@ -621,7 +621,8 @@ private static String serialize(CompositeSerializer serializer, Object value) { | |||
| || value instanceof Number | |||
| || value instanceof Boolean | |||
| || value instanceof Character | |||
| || value instanceof DateTimeRfc1123) { | |||
| || value instanceof DateTimeRfc1123 | |||
| || value instanceof Base64Uri) { | |||
There was a problem hiding this comment.
The current process in the function seems not general enough. E.g. if I need to handle Duration in query/header parameter, I will need to put the Duration class there as well.
6 tasks
weidongxu-microsoft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test in #44319
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines