-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Regenerate azure.ai.vision.face #53268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7c91393
to
a72fc6c
Compare
/azp run net - face - tests |
/azp run net - face - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
a72fc6c
to
bd10ea9
Compare
/azp run net - face - tests |
/azp run net - face - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
bd10ea9
to
ff6299c
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
ff6299c
to
65df068
Compare
/// <exception cref="ArgumentNullException"> <paramref name="jsonContent"/> is null. </exception> | ||
/// <remarks> Please refer to https://learn.microsoft.com/rest/api/face/liveness-session-operations/create-liveness-with-verify-session-with-verify-image for more details. </remarks> | ||
[ForwardsClientCalls] | ||
public virtual async Task<Response<CreateLivenessWithVerifySessionResult>> CreateLivenessWithVerifySessionAsync(CreateLivenessWithVerifySessionContent jsonContent, Stream verifyImage, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These operations seem to no longer be supported in the new api versions.
/azp run net - face - tests |
/azp run net - face - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
65df068
to
d310785
Compare
d310785
to
e93c6cc
Compare
/azp run net - face - tests |
/azp run net - face - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR regenerates the Azure.AI.Vision.Face SDK to consume TypeSpec breaking changes by updating the spec references to the latest commit. The changes primarily involve API restructuring to align with the new TypeSpec schema, particularly affecting liveness detection session operations.
Key changes:
- Updated service API versions to support v1.2 and v1.3-preview.1
- Removed deprecated session listing and audit entry operations
- Restructured session creation/result models to use new schema with attempts-based results
- Modified API signatures to integrate verify images into session content
Reviewed Changes
Copilot reviewed 20 out of 77 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tsp-location.yaml | Updated spec commit reference to latest version |
FaceSessionClientTests.cs | Updated tests to use new session models and removed deprecated list/audit operations |
Sample files (*.cs, *.md) | Updated sample code to use new session result structure with attempts |
FaceSessionClient.cs | Removed custom overloads for verify image handling |
Custom model files | Added new properties for abuse monitoring and client attempts |
API surface files | Reflected breaking changes in public API including new models and removed deprecated types |
assets.json | Updated test asset tag reference |
CHANGELOG.md | Documented new service versions and breaking changes |
sdk/face/Azure.AI.Vision.Face/tests/FaceSessionClient/FaceSessionClientTests.cs
Show resolved
Hide resolved
sdk/face/Azure.AI.Vision.Face/tests/FaceSessionClient/FaceSessionClientTests.cs
Outdated
Show resolved
Hide resolved
sdk/face/Azure.AI.Vision.Face/tests/samples/Sample3_DetectLivenessWithVerifyWithSession.cs
Outdated
Show resolved
Hide resolved
…ionClientTests.cs Co-authored-by: Copilot <[email protected]>
…nessWithVerifyWithSession.cs Co-authored-by: Copilot <[email protected]>
This PR bumps the spec references to the latest commit to consume a breaking change from Typespec, and it regenerates the library.
fixes: microsoft/typespec#8747