[ContainerRegistry] SDK validation for TypeSpec #53318
Open
+3,548
−2,466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
HarveyLink
requested review from
a team,
ArcturusZhang and
ArthurMa1978
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds new ContainerRegistry TypeSpec-based API version tag and introduces compatibility shims for operations that are no longer long‑running (LRO), along with new model properties for upcoming service features.
- Adds tag package-2025-11-dotnetmix and updates autorest configuration and input files.
- Introduces non-LRO overloads plus legacy LRO-shaped methods (hidden via EditorBrowsable.Never) for ScheduleRun, Update, and Cancel operations.
- Extends models with new properties (e.g., RoleAssignmentMode, AutoGeneratedDomainNameLabelScope, SourceRegistryCredentials, NetworkRuleBypassAllowedForTasks) and adjusts PrivateLink resource data shape.
Reviewed Changes
Copilot reviewed 12 out of 118 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs | Adds using directive (likely supporting newly referenced types in compatibility code). |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/autorest.md | Points to new spec location and introduces 2025-11 mix tag for generation. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/Models/ContainerRegistryCredentials.cs | Adds compatibility property SourceRegistryLoginMode wired to new SourceRegistryCredentials model. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/LongRunningOperation/ContainerRegistryTaskOperationSource.cs | Minor header normalization (BOM / removal of auto-generated tag). |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/LongRunningOperation/ContainerRegistryRunOperationSource.cs | Minor header normalization (BOM / removal of auto-generated tag). |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryTaskResource.cs | Adds legacy LRO-shaped Update overloads for compatibility. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryRunResource.cs | Adds legacy LRO-shaped Cancel/Update overloads for compatibility. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryResource.cs | Adds legacy LRO-shaped ScheduleRun overloads for compatibility. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryPrivateLinkResourceData.cs | Adds RequiredZoneNames compatibility wrapper over new RequiredZoneNamesList. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/assets.json | Updates assets tag to new revision. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/api/Azure.ResourceManager.ContainerRegistry.netstandard2.0.cs | Declares new surface area (properties, types, overloads) for netstandard2.0 target. |
| sdk/containerregistry/Azure.ResourceManager.ContainerRegistry/api/Azure.ResourceManager.ContainerRegistry.net8.0.cs | Declares new surface area (properties, types, overloads) for net8.0 target. |
...registry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryTaskResource.cs
Show resolved
Hide resolved
...registry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryTaskResource.cs
Show resolved
Hide resolved
...rregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryRunResource.cs
Outdated
Show resolved
Hide resolved
...rregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryRunResource.cs
Outdated
Show resolved
Hide resolved
...rregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryRunResource.cs
Show resolved
Hide resolved
...ourceManager.ContainerRegistry/api/Azure.ResourceManager.ContainerRegistry.netstandard2.0.cs
Show resolved
Hide resolved
...registry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryTaskResource.cs
Outdated
Show resolved
Hide resolved
...rregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryRunResource.cs
Outdated
Show resolved
Hide resolved
...inerregistry/Azure.ResourceManager.ContainerRegistry/src/Custom/ContainerRegistryResource.cs
Outdated
Show resolved
Hide resolved
...ry/Azure.ResourceManager.ContainerRegistry/src/Custom/Models/ContainerRegistryCredentials.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
| /// <summary> The private link resource Private link DNS zone name. </summary> | ||
| [WirePath("properties.requiredZoneNames")] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public IReadOnlyList<string> RequiredZoneNames { get => (IReadOnlyList<string>)RequiredZoneNamesList; } |
There was a problem hiding this comment.
RequiredZoneNamesList is not really a good name - we could make it RequiredPrivateLinkZoneNames according to its description
There was a problem hiding this comment.
Renamed to RequiredPrivateLinkZoneNames
Co-authored-by: Copilot <[email protected]>
…yLink/azure-sdk-for-net into v-minghc-containerregistry
jsquire
requested changes
Oct 20, 2025
| using System.IO; | ||
| using System.Linq; | ||
| using System.Net; | ||
| using System.Text; |
There was a problem hiding this comment.
This change has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.