Skip to content

Conversation

jrjrguo
Copy link
Member

@jrjrguo jrjrguo commented Oct 17, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 23:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces a new preview service version and significant API surface changes for the Text Translation SDK, removing previous dictionary and sentence-breaking features while renaming and reshaping existing translation models.

  • Adds a new (mismatched) preview service version mapping and updates version to 1.1.0.
  • Renames model properties (e.g., Confidence -> Score, Directionality -> Dir, TargetLanguage -> To) and introduces new request body types (TranslateBody, TranslateTarget) while tests and samples still reference old property names.
  • Removes samples/tests for dictionary lookup/examples and break sentence, but introduces LLM translation usage without corresponding validation tests.

Reviewed Changes

Copilot reviewed 25 out of 78 changed files in this pull request and generated 26 comments.

Show a summary per file
File Description
tsp-location.yaml Updates spec directory and commit reference for generator input.
TransliterationLiveTests.cs Adjusts transliteration response type; removes option-based tests.
TranslationLiveTests.cs Updates tests to new response hierarchy but leaves outdated property usages and logic errors.
Samples (multiple Sample*.cs) Removes dictionary/break sentence samples; updates translation/transliteration samples to new API but retains obsolete property names.
Sample0_CreateClient.cs Updates error scenario to new Translate overload.
GetLanguagesLiveTests.cs Aligns property names (Directionality -> Dir, TargetLanguageScripts -> ToScripts).
Deleted live test files (Dictionary*, BreakSentence*) Removes coverage for deprecated endpoints/features.
TextTranslationTransliterateOptions.cs Removes custom transliterate options class.
TextTranslationTranslateOptions.cs Removes custom translate options class.
TextTranslationClientOptions.cs Adds mapping for new preview version (mismatch with public API enum).
Azure.AI.Translation.Text.csproj Bumps package version to 1.1.0 and removes ApiCompatVersion.
API surface files (*.netstandard2.0.cs, *.net8.0.cs) Reflects large API changes; new types and renamed properties, but missing alignment with tests and client options.
README.md Updates version table; removes documentation for removed endpoints (dictionary, break sentence).
Comments suppressed due to low confidence (2)

sdk/translation/Azure.AI.Translation.Text/tests/TranslationLiveTests.cs:1

  • Similar to other occurrences: property 'Language' should be 'To', and the response type likely does not have nested '.Value.Value' if API was not updated to include a TranslationResult wrapper.
// Copyright (c) Microsoft Corporation. All rights reserved.

sdk/translation/Azure.AI.Translation.Text/tests/TranslationLiveTests.cs:1

  • Tests expect Response with nested Value.Value indexing; public API (model factory removal) no longer shows a TransliterateResult type—confirm the new return type (likely IReadOnlyList) and adjust assertions accordingly.
// Copyright (c) Microsoft Corporation. All rights reserved.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrjrguo:

Your account lacks a public membership to the Microsoft GitHub organization that we require of an internal contributor. Your membership is currently marked as private. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository

@jrjrguo
Copy link
Member Author

jrjrguo commented Oct 19, 2025

@jrjrguo:

Your account lacks a public membership to the Microsoft GitHub organization that we require of an internal contributor. Your membership is currently marked as private. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository

Thanks. I've joined Microsoft and verified that both Microsoft and Azure are now public.

@jrjrguo
Copy link
Member Author

jrjrguo commented Oct 19, 2025

@microsoft-github-policy-service agree company="Microsoft"

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.AI.Translation.Text

@jsquire jsquire dismissed their stale review October 19, 2025 18:11

Account issues confirmed resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants