[AutoRelease] t2-dependencymap-2025-03-25-78535(can only be merged by SDK owner) #40210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
ChenxiJiang333,
msyyc and
lmazuel
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial release of the Microsoft Azure Dependencymap Management Client Library. It creates both synchronous and asynchronous clients, adds configuration and models, and updates the README and CHANGELOG to document the release.
- New synchronous and asynchronous client implementations with respective configurations.
- Introduction of auto-generated code for service operations, models, and patching.
- Added documentation and changelog for the initial release.
Reviewed Changes
Copilot reviewed 55 out of 59 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure/mgmt/dependencymap/init.py | Initializes the package with client and version setup. |
| azure/mgmt/dependencymap/aio/init.py | Sets up asynchronous client module with patching. |
| README.md | Provides usage instructions and examples for the client. |
| azure/mgmt/dependencymap/aio/operations/init.py | Registers async operations. |
| azure/mgmt/dependencymap/aio/_configuration.py | Configures the async client using async-specific policies. |
| azure/mgmt/dependencymap/_configuration.py | Configures the synchronous client. |
| azure/mgmt/dependencymap/_client.py | Implements the synchronous client. |
| azure/mgmt/dependencymap/aio/_client.py | Implements the asynchronous client with async context management. |
| CHANGELOG.md | Documents the initial release changes. |
| Other files | Include versioning, model definitions, patch files, and package initialization. |
Files not reviewed (4)
- sdk/dependencymap/azure-mgmt-dependencymap/LICENSE: Language not supported
- sdk/dependencymap/azure-mgmt-dependencymap/MANIFEST.in: Language not supported
- sdk/dependencymap/azure-mgmt-dependencymap/_meta.json: Language not supported
- sdk/dependencymap/azure-mgmt-dependencymap/apiview-properties.json: Language not supported
Comments suppressed due to low confidence (1)
sdk/dependencymap/azure-mgmt-dependencymap/azure/mgmt/dependencymap/_client.py:75
- Filter out potential None values from the policies list before passing it to the ARMPipelineClient to ensure all list items are valid policy instances. This can help prevent unexpected issues during request processing.
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
| self._config.custom_hook_policy, | ||
| self._config.logging_policy, | ||
| policies.DistributedTracingPolicy(**kwargs), | ||
| policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None, |
There was a problem hiding this comment.
Consider filtering out None values from the policies list to avoid passing a None item to the AsyncARMPipelineClient, which could lead to runtime errors. One approach is to use a list comprehension to include only truthy policy instances.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/5961
Recording test success