Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch] Beta Data Plane SDK 15.0.0b2 Update to 07-01-2024 API #40222

Merged
merged 19 commits into from
Apr 4, 2025

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented Mar 26, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot bot review requested due to automatic review settings March 26, 2025 00:01
@github-actions github-actions bot added the Batch label Mar 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Batch Data Plane SDK to beta version 15.0.0b2 in line with the 07-01-2024 API. Key changes include the addition and renaming of various enum types and operational options, conversion of time_out_in_seconds parameters to timeout, and adjustments to both synchronous and asynchronous client implementations and patch operations.

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.

File Description
sdk/batch/azure-batch/azure/batch/models/_enums.py Added new enums and corrected naming inconsistencies (e.g. UPGRADING_O_S to UPGRADING_OS).
sdk/batch/azure-batch/tests/async_wrapper.py Introduced new async wrapper functions and updated type annotations.
sdk/batch/azure-batch/azure/batch/_operations/_patch.py Renamed API parameters (time_out_in_seconds ➔ timeout) and adjusted return types.
Other files Minor modifications in client, configuration, and patch files to align with the new API version and improve type hints.
Files not reviewed (1)
  • sdk/batch/azure-batch/assets.json: Language not supported
Comments suppressed due to low confidence (1)

sdk/batch/azure-batch/tests/async_wrapper.py:18

  • The variable 'items' is annotated as Iterable[T] but is initialized as a list to which items are appended. Consider changing the type annotation to List[T] for clarity.
items: Iterable[T] = []

@scbedd
Copy link
Member

scbedd commented Mar 26, 2025

/azp run python - pullrequest

1 similar comment
@scbedd
Copy link
Member

scbedd commented Mar 26, 2025

/azp run python - pullrequest

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-batch

@cRui861 cRui861 merged commit 8b5fbd8 into main Apr 4, 2025
24 checks passed
@cRui861 cRui861 deleted the rechen/batch-24-07-01-t2-retry2 branch April 4, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants