Sync eng/common directory with azure-sdk-tools for PR 10038 #40283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common pipeline templates with updates from azure-sdk-tools for PR 10038. The changes include the introduction of a new parameter "PreTestSteps" and its subsequent integration into the pipeline steps layout.
Files not reviewed (1)
- eng/common/scripts/Package-Properties.ps1: Language not supported
Comments suppressed due to low confidence (2)
eng/common/pipelines/templates/stages/archetype-sdk-tool-pwsh.yml:14
- The parameter 'PreTestSteps' is declared as type 'object' with a default value of an empty list. If this parameter is intended to represent a list of steps, consider declaring it as a list (e.g., object[] or array) to better reflect its expected structure.
type: object
eng/common/pipelines/templates/stages/archetype-sdk-tool-pwsh.yml:42
- When inserting 'PreTestSteps' into the steps array, verify that its expansion produces the intended YAML structure. If 'PreTestSteps' is an array of steps, the current usage with an extra dash may introduce an unwanted level of nesting.
- ${${ parameters.PreTestSteps }}
scbedd
approved these changes
Apr 1, 2025
…to enable go to actually match some packages during checks
… on js specifically artifactname isn't populated yet
azure-sdk
force-pushed
the
sync-eng/common-further-package-props-tests-10038
branch
from
cf5288f to
996eb14
Compare
scbedd
approved these changes
Apr 1, 2025
weirongw23-msft
pushed a commit
to weirongw23-msft/azure-sdk-for-python
that referenced
this pull request
Apr 4, 2025
) * add a category to parse triggerPaths when there is no artifact present (this is the go use-case) * add integration tests for Save-Package-Properties scenarios * bugfixes around various situations in new PackageProps class --------- Co-authored-by: Scott Beddall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10038 See eng/common workflow