Skip to content

Added recording result api #41704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 23, 2025

Conversation

amariwest-msft
Copy link
Contributor

@amariwest-msft amariwest-msft commented Jun 20, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings June 20, 2025 21:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new recording result API and updates the end‐to‐end test coverage for call automation. Key changes include updating test functions to trigger recording result retrieval, renaming functions and variables to reflect the new API, and revising JSON event fixtures to support the enhanced recording results.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

File Description
sdk/communication/azure-communication-callautomation/tests/test_e2e_callautomation_client.py Updated the recording tests to validate the recording result API and renamed test functions/variables accordingly.
Remaining test files Revised JSON event fixtures to support recording result events and adjust expected event payloads.

Copy link

github-actions bot commented Jun 20, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-communication-callautomation

@amariwest-msft amariwest-msft merged commit 55a58b9 into main Jun 23, 2025
19 checks passed
@amariwest-msft amariwest-msft deleted the amariwest/feature/getRecordingCompleteData branch June 23, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants