-
Notifications
You must be signed in to change notification settings - Fork 3k
[sdk generation pipeline] simplify generation scripts #41708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: msyyc <[email protected]>
Co-authored-by: msyyc <[email protected]>
…integrated into sdk_generator.py Co-authored-by: msyyc <[email protected]>
Co-authored-by: msyyc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the SDK generation pipeline by consolidating generation and packaging steps and removing redundant packaging components. Key changes include:
- Removal of the deprecated sdk_package module and its corresponding CLI command.
- Consolidation of code generation and packaging into a single step in shell scripts.
- Updates to sdk_generator.py for improved error handling and additional logging.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tools/azure-sdk-tools/setup.py | Removed the sdk_package CLI command to simplify setup. |
tools/azure-sdk-tools/packaging_tools/sdk_package.py | Entire file removed as part of the code simplification. |
tools/azure-sdk-tools/packaging_tools/sdk_generator.py | Added a timeout wrapper using multiprocessing and improved error logging. |
scripts/sdk_generate.sh | Merged generation and packaging steps into one command with updated logging. |
scripts/automation_generate.sh | Same consolidation update as sdk_generate.sh. |
scripts/auto_release/main.py | Removed package size check logic and updated extraction of tag and PR body generation. |
Comments suppressed due to low confidence (1)
tools/azure-sdk-tools/packaging_tools/sdk_generator.py:397
- The variable 'run_in_pipeline' is used without a clear definition in this scope. Please verify its intended assignment or replace it with the correct variable to ensure proper pipeline execution.
if run_in_pipeline:
/check-enforcer override |
fix #41692