Skip to content

[sdk generation pipeline] simplify generation scripts #41708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 23, 2025
Merged

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Jun 21, 2025

fix #41692

@msyyc msyyc marked this pull request as ready for review June 23, 2025 08:06
@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 08:06
@msyyc msyyc requested review from scbedd and mccoyp as code owners June 23, 2025 08:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the SDK generation pipeline by consolidating generation and packaging steps and removing redundant packaging components. Key changes include:

  • Removal of the deprecated sdk_package module and its corresponding CLI command.
  • Consolidation of code generation and packaging into a single step in shell scripts.
  • Updates to sdk_generator.py for improved error handling and additional logging.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/azure-sdk-tools/setup.py Removed the sdk_package CLI command to simplify setup.
tools/azure-sdk-tools/packaging_tools/sdk_package.py Entire file removed as part of the code simplification.
tools/azure-sdk-tools/packaging_tools/sdk_generator.py Added a timeout wrapper using multiprocessing and improved error logging.
scripts/sdk_generate.sh Merged generation and packaging steps into one command with updated logging.
scripts/automation_generate.sh Same consolidation update as sdk_generate.sh.
scripts/auto_release/main.py Removed package size check logic and updated extraction of tag and PR body generation.
Comments suppressed due to low confidence (1)

tools/azure-sdk-tools/packaging_tools/sdk_generator.py:397

  • The variable 'run_in_pipeline' is used without a clear definition in this scope. Please verify its intended assignment or replace it with the correct variable to ensure proper pipeline execution.
            if run_in_pipeline:

@msyyc
Copy link
Member Author

msyyc commented Jun 23, 2025

/check-enforcer override

@msyyc msyyc merged commit 0e9354e into main Jun 23, 2025
12 of 17 checks passed
@msyyc msyyc deleted the merge-scripts branch June 23, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python][copilot] combine script sdk_package into sdk_generator
3 participants