Conversation
There was a problem hiding this comment.
Pull request overview
Updates MCP-specific labeling/config behavior across the issue-labeler SearchIndexCreator and the GitHub event processor by moving MCP label prefix logic into configuration and removing the Azure App Configuration-based MCP team-mapping.
Changes:
- Make MCP label prefix matching configurable via
PrimaryLabelPrefixes/SecondaryLabelPrefixesand threadIConfigurationthrough MCP repo config creation. - Update MCP label filtering/docs to include
packages-*and use prefix-based matching. - Remove Azure App Configuration wiring (
McpConfiguration, related packages, workflow env var) and switch MCP triage comments to derive mentions from CODEOWNERS.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/issue-labeler/src/SearchIndexCreator/RepositoryIndexConfigs/RepositoryIndexConfigFactory.cs | Passes IConfiguration into MCP repository config creation. |
| tools/issue-labeler/src/SearchIndexCreator/RepositoryIndexConfigs/McpRepositoryIndexConfig.cs | Reads MCP label prefixes from configuration instead of hard-coded checks. |
| tools/issue-labeler/src/SearchIndexCreator/README.md | Updates MCP label description to include packages-*. |
| tools/issue-labeler/src/SearchIndexCreator/LabelRetrieval.cs | Makes MCP label filtering prefix-config-driven. |
| tools/issue-labeler/src/SearchIndexCreator/IssueTriageContentRetrieval.cs | Updates factory call to pass configuration through. |
| tools/issue-labeler/src/SearchIndexCreator/IssueTriageContentIndex.cs | Updates factory call to pass configuration through. |
| tools/issue-labeler/src/Mcp.Evaluator/McpLabelerTool.cs | Switches evaluator credential type to AzureCliCredential. |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Program.cs | Removes MCP Azure App Configuration bootstrap/DI registration. |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/EventProcessing/McpIssueProcessing.cs | Uses CODEOWNERS-derived mentions for MCP server-team comments; expands tool label detection. |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Constants/McpConstants.cs | Adds packages- to MCP “other tool labels”. |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Configuration/McpConfiguration.cs | Deleted (removes Azure App Configuration-based mapping). |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Azure.Sdk.Tools.GitHubEventProcessor.csproj | Removes Azure App Configuration and Azure.Identity package refs. |
| tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor.Tests/Static/McpIssueProcessingTests.cs | Updates MCP processing tests to align with CODEOWNERS mention behavior. |
| .github/workflows/event-processor.yml | Removes APP_CONFIG_ENDPOINT retrieval/passing since it’s no longer used. |
...event-processor/Azure.Sdk.Tools.GitHubEventProcessor.Tests/Static/McpIssueProcessingTests.cs
Outdated
Show resolved
Hide resolved
tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Constants/McpConstants.cs
Outdated
Show resolved
Hide resolved
tools/issue-labeler/src/SearchIndexCreator/RepositoryIndexConfigs/McpRepositoryIndexConfig.cs
Outdated
Show resolved
Hide resolved
tools/issue-labeler/src/SearchIndexCreator/RepositoryIndexConfigs/McpRepositoryIndexConfig.cs
Outdated
Show resolved
Hide resolved
...b-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/EventProcessing/McpIssueProcessing.cs
Outdated
Show resolved
Hide resolved
jsquire
left a comment
There was a problem hiding this comment.
We've been experimenting with the Agentic workflows for triage and labeling with good results in both .NET and Rust.
I'd suggest taking a look at that path and seeing if we can shift to that. I believe that we'll be looking to move all the repositories in that direction sooner rather than later. Given that MCP is both new and has a labeling pattern that is very different than the Azure SDK repositories, I think it would be quite helpful.
tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/Constants/McpConstants.cs
Outdated
Show resolved
Hide resolved
Aah, Thank you for pointing this out, Jesse! I wasn't aware of this- I'll start digging into the details to understand how we can incorporate this into MCP. I'd love to discuss more on this once I've got a better grasp of it. :) |
This PR updates the MCP Issue Labeler configuration with the following changes:
EventProcessor. Server mappings are now dynamically fetched from the CODEOWNERS file. We're now using the app configuration to fetch prefixes.packages-*tool label prefix added to the MCP repository. To accommodate this and any future label prefix changes, label definitions have been moved to configuration, allowing updates to be picked up without requiring code changes.microsoft/mcp#2272