Benchmarks fix reporting going over token count#14837
Open
jeo02 wants to merge 9 commits intoAzure:mainfrom
Open
Benchmarks fix reporting going over token count#14837jeo02 wants to merge 9 commits intoAzure:mainfrom
jeo02 wants to merge 9 commits intoAzure:mainfrom
Conversation
Member
jeo02
commented
Mar 31, 2026
- Benchmarks reports were adding to much information into result and causing rate limiting,
- Avoid telemetry.
- Remove do not verify setup from tests that don't need to avoid it
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azsdk-cli benchmarks harness to reduce oversized benchmark outputs (to avoid rate limiting), disable telemetry during benchmark runs, and simplify several benchmark scenario prompts/validators around setup verification.
Changes:
- Reduce benchmark tool-call reporting payload by omitting args/results for non-
azsdk_tools and removing the recorded MCP server name field. - Disable telemetry during benchmark workspace execution via
AZSDKTOOLS_COLLECT_TELEMETRY=false. - Remove “do not run azsdk_verify_setup” prompt text and the corresponding
forbiddenToolNamesrestriction from several scenarios.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/GetModifiedTypespecProjectsScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/CheckPublicRepoThenValidateScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/CheckPublicRepoScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/ReleasePlan/LinkNamespaceApprovalIssueScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/ReleasePlan/CreateReleasePlanScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup and tightens prompt wording. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/Pipeline/CheckSdkGenerationStatusScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/GitHub/GetPrLinkCurrentBranchScenario.cs | Removes prompt instruction and validator restriction related to azsdk_verify_setup. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Models/ToolCallRecord.cs | Removes the McpServerName field from captured tool call records. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/WorkspaceManager.cs | Disables telemetry for benchmark runs via environment variable. |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/SessionExecutor.cs | Filters captured tool args/results to reduce benchmark output size. |
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Infrastructure/SessionExecutor.cs
Outdated
Show resolved
Hide resolved
.../azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/GitHub/GetPrLinkCurrentBranchScenario.cs
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Reporting/ReportGenerator.cs
Outdated
Show resolved
Hide resolved
...cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/GetModifiedTypespecProjectsScenario.cs
Show resolved
Hide resolved
...cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/CheckPublicRepoThenValidateScenario.cs
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/TypeSpec/CheckPublicRepoScenario.cs
Show resolved
Hide resolved
...i/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/ReleasePlan/LinkNamespaceApprovalIssueScenario.cs
Show resolved
Hide resolved
.../azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/ReleasePlan/CreateReleasePlanScenario.cs
Show resolved
Hide resolved
...dk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Scenarios/Pipeline/CheckSdkGenerationStatusScenario.cs
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Reporting/ReportGenerator.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Benchmarks/Reporting/ReportGenerator.cs
Outdated
Show resolved
Hide resolved
praveenkuttappan
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.