-
Notifications
You must be signed in to change notification settings - Fork 101
feat(helmchart): Extend helm chart to include automount toggle for service account #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vakaobr
wants to merge
23
commits into
Azure:main
Choose a base branch
from
vakaobr:extend-helm-chart-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for service account Signed-off-by: Anderson Leite <[email protected]>
@microsoft-github-policy-service agree |
… for service account Signed-off-by: Anderson Leite <[email protected]>
… for service account Signed-off-by: Anderson Leite <[email protected]>
… for service account Signed-off-by: Anderson Leite <[email protected]>
… for service account Signed-off-by: Anderson Leite <[email protected]>
… for service account Signed-off-by: Anderson Leite <[email protected]>
aramase
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
- You need to update the helm chart generator here with the changes and then run
make generate
. - Also need to add the new variable in the helm chart readme with a description on what it means.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
automountServiceAccountToken
property set tofalse
, but setting this to false introduces the need to set the property totrue
explicitly inside the deployment, in order to have the token/certs mounted to the pods.Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: