Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCE updates] update calling-effects #5644

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dmceachernmsft
Copy link
Member

What

Update the Calling Effects package to 1.1.3

Why

Keeps us up to date and resolves the mic switch error

How Tested

Validated the changes locally

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Feb 12, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27986 / 44652
62.67%
27986 / 44652
62.67%
786 / 1436
54.73%
2352 / 3718
63.25%
Current 28049 / 44652
62.81%
28049 / 44652
62.81%
786 / 1436
54.73%
2380 / 3740
63.63%
Diff 63 / 0
0.14%
63 / 0
0.14%
0 / 0
0%
28 / 22
0.38%

Copy link
Contributor

github-actions bot commented Feb 12, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58224 / 94181
61.82%
58224 / 94181
61.82%
1177 / 2693
43.7%
3563 / 5837
61.04%
Current 58256 / 94181
61.85%
58256 / 94181
61.85%
1177 / 2693
43.7%
3532 / 5828
60.6%
Diff 32 / 0
0.03%
32 / 0
0.03%
0 / 0
0%
-31 / -9
-0.44%

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1777977
  • Base size: 1777282
  • Diff size: 695

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) February 15, 2025 00:56
Copy link
Contributor

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants