-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bing Grounding Resource, introduce Azure AI Agents for Lesson 6 and API #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 25 changed files in this pull request and generated no comments.
Files not reviewed (15)
- workshop/dotnet/App/backend/backend.csproj: Language not supported
- workshop/dotnet/Core.Utilities/Core.Utilities.csproj: Language not supported
- workshop/dotnet/Directory.Packages.props: Language not supported
- workshop/dotnet/Lessons/appsettings.json.example: Language not supported
- workshop/dotnet/infra/app/api.bicep: Language not supported
- workshop/dotnet/infra/core/host/container-app-upsert.bicep: Language not supported
- workshop/dotnet/infra/core/security/subscription-role.bicep: Language not supported
- docs/wksp/05-semantic-kernel-workshop/simple-ai-orchestration/create-deployable-app/azd-infra.md: Evaluated as low risk
- workshop/dotnet/Core.Utilities/Config/KernelBuilderProvider.cs: Evaluated as low risk
- workshop/dotnet/App/backend/Extensions/ServiceExtensions.cs: Evaluated as low risk
- docs/wksp/00-intro/pre-reqs.md: Evaluated as low risk
- workshop/dotnet/Lessons/Lesson6/Program.cs: Evaluated as low risk
- workshop/dotnet/Core.Utilities/Config/AISettingsProvider.cs: Evaluated as low risk
- workshop/dotnet/Solutions/Lesson6/Program.cs: Evaluated as low risk
- workshop/dotnet/Core.Utilities/Models/AppSettings.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
workshop/dotnet/App/backend/Controllers/ChatController.cs:0
- Ensure that the new Azure AI Agent integration is thoroughly tested.
N/A
workshop/dotnet/Core.Utilities/Plugins/StockDataPlugin.cs:23
- Ensure that the
DateTime.Parse
operation is covered by tests, including cases with invalid date formats.
var dateTime = DateTime.Parse(date);
…telligent-app-workshop into bing-grounding-azure-ai
…telligent-app-workshop into bing-grounding-azure-ai
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - verified and tested
Purpose
Introduce Grounding with Bing Search in place of bing search resource with deployment restrictions. Introduce Azure AI Agent service to do the grounded search.
Update instructions, back end API, Lesson 6 and infrastructure. Made small change to
StockDataPlugin
because it had issues marshalling data types after Azure AI Agent was introduced.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Follow deployment instructions and test both lesson 6 and the back end API (locally and/or deployed with bicep)
What to Check
Verify that the following are valid