Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bing Grounding Resource, introduce Azure AI Agents for Lesson 6 and API #38

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

adrianwright
Copy link
Collaborator

@adrianwright adrianwright commented Feb 19, 2025

Purpose

Introduce Grounding with Bing Search in place of bing search resource with deployment restrictions. Introduce Azure AI Agent service to do the grounded search.

Update instructions, back end API, Lesson 6 and infrastructure. Made small change to StockDataPlugin because it had issues marshalling data types after Azure AI Agent was introduced.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow deployment instructions and test both lesson 6 and the back end API (locally and/or deployed with bicep)

What to Check

Verify that the following are valid

  • Lessons working as intended
  • Back end api working as intended locally
  • Bicep deploys successfully
  • Back end api working as intended when deployed

@adrianwright adrianwright requested a review from yortch February 19, 2025 19:17
@yortch yortch requested a review from Copilot February 20, 2025 14:05

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 25 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • workshop/dotnet/App/backend/backend.csproj: Language not supported
  • workshop/dotnet/Core.Utilities/Core.Utilities.csproj: Language not supported
  • workshop/dotnet/Directory.Packages.props: Language not supported
  • workshop/dotnet/Lessons/appsettings.json.example: Language not supported
  • workshop/dotnet/infra/app/api.bicep: Language not supported
  • workshop/dotnet/infra/core/host/container-app-upsert.bicep: Language not supported
  • workshop/dotnet/infra/core/security/subscription-role.bicep: Language not supported
  • docs/wksp/05-semantic-kernel-workshop/simple-ai-orchestration/create-deployable-app/azd-infra.md: Evaluated as low risk
  • workshop/dotnet/Core.Utilities/Config/KernelBuilderProvider.cs: Evaluated as low risk
  • workshop/dotnet/App/backend/Extensions/ServiceExtensions.cs: Evaluated as low risk
  • docs/wksp/00-intro/pre-reqs.md: Evaluated as low risk
  • workshop/dotnet/Lessons/Lesson6/Program.cs: Evaluated as low risk
  • workshop/dotnet/Core.Utilities/Config/AISettingsProvider.cs: Evaluated as low risk
  • workshop/dotnet/Solutions/Lesson6/Program.cs: Evaluated as low risk
  • workshop/dotnet/Core.Utilities/Models/AppSettings.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

workshop/dotnet/App/backend/Controllers/ChatController.cs:0

  • Ensure that the new Azure AI Agent integration is thoroughly tested.
N/A

workshop/dotnet/Core.Utilities/Plugins/StockDataPlugin.cs:23

  • Ensure that the DateTime.Parse operation is covered by tests, including cases with invalid date formats.
var dateTime = DateTime.Parse(date);
@yortch yortch marked this pull request as draft February 20, 2025 22:07
@yortch yortch marked this pull request as ready for review February 21, 2025 19:29
@adrianwright
Copy link
Collaborator Author

adrianwright commented Feb 21, 2025

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Collaborator

@yortch yortch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - verified and tested

@yortch yortch merged commit 3be4501 into main Feb 21, 2025
1 check passed
@yortch yortch deleted the bing-grounding-azure-ai branch February 21, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants