Skip to content

eng, feeds, arm, update tspconfig template #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Apr 29, 2025

The service-name in Java is recommended to be uppercase with whitespace.

related to Azure/azure-rest-api-specs#34114

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website

@@ -19,7 +19,7 @@ options:
"@azure-tools/typespec-java":
package-dir: "azure-resourcemanager-{{#toLowerCase}}{{parameters.ServiceNamespace}}{{/toLowerCase}}"
namespace: "com.azure.resourcemanager.{{#toLowerCase}}{{parameters.ServiceNamespace}}{{/toLowerCase}}"
service-name: "{{#toLowerCase}}{{parameters.ServiceNamespace}}{{/toLowerCase}}"
service-name: "{{#toUpperCase}}{{parameters.ServiceNamespace}}{{/toUpperCase}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is service-name supposed to be Pascal case or upper case?

Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pascal case.

Thanks. #toUpperCase would be wrong. How do I write "convert to Pascal case" here? I am still not sure what's the syntax used in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already with 'Pascal case'. You could close this PR.

"description": "Please provide ARM Resource Provider Name in Pascal case, excluding the 'Microsoft.' prefix:",

Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure whether this is related.

ARM Resource Provider Name could be a same Microsoft.Workloads in all folders under https://github.com/Azure/azure-rest-api-specs/tree/main/specification/workloads, but each folder would generate different SDK and different service-name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scaffolding template only supports a RP with single service scenario.

@markcowl
Copy link
Member

Per the above conversation, I think this should be closed. Please re-open or let me know if this is not the case.

@markcowl markcowl closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants