Skip to content

[tcgc] convert to same type for array or dictionary of same type #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2025
Merged

[tcgc] convert to same type for array or dictionary of same type #2626

merged 5 commits into from
May 7, 2025

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented May 6, 2025

fix: #2595

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 6, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

Convert to same type for array or dictionary of same type.

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 6, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website

qiaozha
qiaozha approved these changes May 6, 2025
View reviewed changes
@iscai-msft iscai-msft enabled auto-merge May 6, 2025 22:44
weidongxu-microsoft
weidongxu-microsoft approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for Java.

Does it also affect the generated name? E.g. previous the 2 A[] would be 2 different type and having different generated name (or tcgc didn't generate name for array?).

@tadelesh
Copy link
Member Author

tadelesh commented May 7, 2025

Should be fine for Java.

Does it also affect the generated name? E.g. previous the 2 A[] would be 2 different type and having different generated name (or tcgc didn't generate name for array?).

tcgc does not generate name for array or dictionary.

@iscai-msft iscai-msft added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit f0e8163 May 7, 2025
22 checks passed
@iscai-msft iscai-msft deleted the tcgc/cache_array_map branch May 7, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@qiaozha qiaozha qiaozha approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: tcgc generate different types for the same typespec dict type
5 participants
@tadelesh @azure-sdk @weidongxu-microsoft @qiaozha @iscai-msft