Skip to content

Remove @AzureAD/MSAL-ObjC-CIAM from CODEOWNERS#2932

Draft
Copilot wants to merge 3 commits into
devfrom
copilot/remove-msal-objc-ciam-ownership
Draft

Remove @AzureAD/MSAL-ObjC-CIAM from CODEOWNERS#2932
Copilot wants to merge 3 commits into
devfrom
copilot/remove-msal-objc-ciam-ownership

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Simplify CODEOWNERS file by removing redundant specific path entries
  • All paths now implicitly owned by @AzureAD/AppleIdentityTeam via the wildcard rule
Original prompt

Update the CODEOWNERS file to remove all references to @AzureAD/MSAL-ObjC-CIAM.

Current file

The current CODEOWNERS file is located at the root of the repo: https://github.com/AzureAD/microsoft-authentication-library-for-objc/blob/8e4217892fc335d5dd86cb8692f0b994990dd3ac/CODEOWNERS

Changes Required

  1. Remove the co-owner comment referencing @AzureAD/MSAL-ObjC-CIAM (line 5)
  2. Remove @AzureAD/MSAL-ObjC-CIAM from all lines where it is a co-owner alongside @AzureAD/AppleIdentityTeam:
    • /MSAL/MSAL.xcodeproj/project.pbxproj
    • CHANGELOG.md
    • /azure_pipelines/
    • /Package.swift
    • /MSAL/src/public/MSAL.h
  3. Remove entirely all lines where @AzureAD/MSAL-ObjC-CIAM is the sole owner (these will fall back to the default * owner @AzureAD/AppleIdentityTeam):
    • /MSAL/module.modulemap
    • /MSAL/.swiftlint.yml
    • /MSAL/src/native_auth/
    • /MSAL/test/unit/native_auth/
    • /MSAL/test/integration/native_auth/
    • /MSAL/MSAL\ iOS\ Native\ Auth\ E2E\ Tests.xctestplan
    • /MSAL/test/testplan/NativeAuthEndToEndTestPlan.xctestplan
    • /MSAL/test/testplan/NativeAuthEndToEndTestPlan\ Mac.xctestplan
    • /MSAL/test/testplan/MSAL\ iOS\ Native\ Auth\ E2E\ Tests.xctestplan
    • /MSAL/test/testplan/MSAL\ Mac\ Native\ Auth\ E2E\ Tests.xctestplan
    • /MSAL/MSAL.xcodeproj/xcshareddata/xcschemes/unit-test-host.xcscheme
    • /MSAL/MSAL.xcodeproj/xcshareddata/xcschemes/unit-test-host-mac.xcscheme
    • /MSAL/MSAL.xcodeproj/xcshareddata/xcschemes/MSAL\ iOS\ Native\ Auth\ E2E\ Tests.xcscheme
    • /MSAL/MSAL.xcodeproj/xcshareddata/xcschemes/MSAL\ Mac\ Native\ Auth\ E2E\ Tests.xcscheme
    • /spm-integration-test.sh
  4. Remove the comment block referencing @AzureAD/MSAL-ObjC-CIAM (lines 11-12)

Expected Result

The final CODEOWNERS file should only contain @AzureAD/AppleIdentityTeam as the owner, with no mentions of @AzureAD/MSAL-ObjC-CIAM anywhere.

The following is the prior conversation context from the user's chat exploration (may be truncated):

Assistant: Here are the ways to remove or update reviewers on a pull request:

Removing a Reviewer (via GitHub UI)

You can remove a requested reviewer directly from the PR:

  1. Open the pull request.
  2. In the right sidebar, find the Reviewers section.
  3. Click the gear icon ⚙️ next to "Reviewers".
  4. Uncheck/deselect the reviewer you want to remove.

Dismissing an Existing Review

If a reviewer has already submitted a review (e.g., "Changes requested") and you need to override it, you can dismiss it (requires write access or admin):

  1. Open the pull request → Conversation tab.
  2. In the merge box, click the chevron (›) to expand the reviews summary.
  3. Next to the review, click ⋯ → Dismiss review.
  4. Provide a reason and confirm.

This changes the review status to a comment, allowing the PR to proceed. See Dismissing a pull request review.

Removing Reviewers via REST API

You can also remove requested reviewers programmatically:

curl -L \
  -X DELETE \
  https://api.github.com/repos/OWNER/REPO/pulls/PULL_NUMBER/requested_reviewers \
  -d '{
  "reviewers": ["username1", "username2"],
  "team_reviewers": ["team-slug"]
}'

See REST API endpoints for review requests for full details.


Note: If your repository has branch protection rules requiring a minimum number of approvals, removing reviewers or dismissing reviews may affect whether the PR can be merged.

User: no i mean from overall repos

Assistant: It sounds like you want to manage who can review PRs across your repositories (i.e., code review limits). Here's how:

At the Repository Level

  1. Go to your repository → Settings
  2. Under Access, click Moderation options
  3. Click Code review limits
  4. Toggle "Limit to users explicitly granted read or higher access" on or off

This controls whether anyone or only explicit collaborators can approve/request changes on PRs.

📖 Managing pull request reviews in your repository


At the Organization Level (applies to all repos)

If you want to update this across all repositories in an organization at once:

  1. Go to your OrganizationSettings
  2. In the sidebar under Access, click Moderation
  3. Click Code review limits
  4. Choose:
    • "Limit review on all repositories" — restricts reviewers to those with explicit access
    • "Remove review limits from all repositories" — opens reviews to everyone

⚠️ Organization-level set...

This pull request was created from Copilot chat.

Copilot AI changed the title [WIP] Update CODEOWNERS file to remove references to @AzureAD/MSAL-ObjC-CIAM Remove @AzureAD/MSAL-ObjC-CIAM from CODEOWNERS Apr 14, 2026
Copilot AI requested a review from swasti29 April 14, 2026 00:04
Comment thread CODEOWNERS
@@ -2,29 +2,11 @@
# Unless a later match takes precedence, these users will be requested
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants