Open
Conversation
kongwoojin
reviewed
Jun 26, 2025
| import android.widget.Toast | ||
| import androidx.recyclerview.widget.RecyclerView | ||
|
|
||
| class MusicAdapter(private val musicList: List<Music>) : |
Contributor
There was a problem hiding this comment.
클래스 이름과 파일 이름을 동일하게 수정해주세요
| android:theme="@style/Theme.BCSD_Android_20251" | ||
| tools:targetApi="31"> | ||
| <activity | ||
| android:name=".Adapter" |
Contributor
There was a problem hiding this comment.
adapter와 data class는 activity가 아니고, androidmanifest에 선언 하지 않아야 합니다
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
| <androidx.recyclerview.widget.RecyclerView | ||
| android:id="@+id/recyclerView" |
Contributor
There was a problem hiding this comment.
xml naming convention은 snake_case입니다
| android:padding="12dp"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/text_list_Title" |
Contributor
There was a problem hiding this comment.
snake_case에서는 대문자를 사용하지 않습니다
| @@ -1,3 +1,11 @@ | |||
| <resources> | |||
| <string name="app_name">BCSD_Android_2025-1</string> | |||
| <string name="play">재생</string> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.