Open
Conversation
kongwoojin
reviewed
Jul 21, 2025
Contributor
kongwoojin
left a comment
kongwoojin
left a comment
There was a problem hiding this comment.
고생하셨습니다.
다만, 과제에 domain 레이어가 보이지 않네요
클린 아키텍쳐에서는 반드시 존재해야 합니다.
그렇기 때문에, ViewModel에서 Repository를 의존성으로 가져서는 안되며, 각 UseCase를 의존성으로 가져야 합니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
김영수 13주차 과제 제출입니다.
glide가 조금 더 자주 사용된다 생각해 glide를 선택하였습니다.
비교와 같은 부분은 13주차 정리 과제에 추가해보도록 하겠습니다.
Clean architecture 구조를 최대한 따라갈 수 있게 하려고 여러 방법을 사용해보았지만 성공했는지는 잘 모르겠습니다.