Open
Conversation
Use CTS seek/length query params to cap initial log fetch at 100KB and provide incremental loading via a "Load more" button in the terminal output area.
|
Prerelease: pr-5 Wheel will be attached once the build completes. Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seek/lengthquery params (added in https://github.com/kbase/cdm_task_service/pull/550)Blocked by
This PR depends on https://github.com/kbase/cdm_task_service/pull/550 being deployed, which adds
seekandlengthquery params toGET /jobs/{jobId}/log/{containerNum}/{stdout|stderr}. Until that's deployed, the params will be ignored and the full log will be returned on first fetch (withhasMorestaying false since the response will be smaller than the requested length).Test plan
uv run jlpm buildpassesuv run jlpm lint:checkpassesuv run jlpm testpasses