MDM_V3_Library4x4 - #8
Conversation
|
|
||
| // Couple of variables for the led animation | ||
| int buttonCounter = 0; | ||
| int expansionCounter = 0; |
There was a problem hiding this comment.
Since this code is made for only 4x4 board with no expansions, we can get rid of "expansionCounter" variable
| if (buttonCounter == 15) | ||
| { | ||
| buttonCounter = 0; | ||
| if (expansionCounter == 1) |
There was a problem hiding this comment.
Get rid of this as mentioned above
| myflag = !myflag; | ||
| } | ||
| else{ | ||
| expansionCounter += 1; |
There was a problem hiding this comment.
Same, remove. Just flip the flag "myflag=!myflag" if buttonCounter == 15
|
The code is actually very similar to this but if you make the requested changes we can merge it. Thanks for taking the time. |
…les/MDM_V3_No_Library_PotentiometerExtension/MDM_V3_No_Library_PotentiometerExtensionMDM_V3_No_Library_PotentiometerExtension.ino
…ntiometerExtension.ino to MDM_V3_No_Library_PotentiometerExtension.ino
Beta test on another library
RGB velocity color future
I forgot to changed |
Ready to merge
Change first button from note 30 to 36 of ableton default drumrack.
|
Could you explain your changes in the commit description? I can't understand what values is |
| * ------------------------------------------------------ | ||
| */ | ||
|
|
||
| const byte _R[128] = {0, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 45, 93, 142, 223, 190, 28, 61, 93, 190, 125, 12, 28, 45, 158, 61, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 0, 0, 0, 125, 0, 12, 28, 45, 158, 61, 28, 61, 93, 190, 125, 45, 93, 142, 223, 190, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 61, 125, 190, 255, 255, 36, 73, 109, 146, 182, 219, 255}; |
There was a problem hiding this comment.
Can you explain what is this doing? Whatever it is, I don't think it should be part of the library, looks quite specific so it should be part of an example.
There was a problem hiding this comment.
Can you explain what is this doing? Whatever it is, I don't think it should be part of the library, looks quite specific so it should be part of an example.
I have made the ledstrip midi like launchpad on arduino pro micro and i want to add the exampke of my project if is possible:
https://github.com/4dvn/Leonardo-Underlights/blob/master/Leonardo/WS2812B/WS2812B.ino
| void MiDispositivoMIDI_V3::generateNotesVeloc(uint8_t numberExtensions) | ||
| { | ||
| int note = 30; | ||
| int note = 36; |
There was a problem hiding this comment.
Why changing this? I saw in one of your commits "first button from note 30 to 36 of ableton default drumrack". I understand your need to do this change, but we can't modify the library for only that specific use case. Instead create a new function with note as input parameter so it can be configured by the user.
| @@ -0,0 +1,24 @@ | |||
| x = [] | |||
There was a problem hiding this comment.
Please, explain in the commit message your changes and which new functionality/feature you are adding. Add a description also for this file. And if you really think that this script is needed, ok, but it shouldn't be in /src since its not really related to the library, is it?
2 participants
No description provided.