Skip to content

SWI-7167 - Replacing ubuntu-20.04 by ubuntu-24.04 on test-pr workflow #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckoegel merged 5 commits into from
Feb 12, 2025
Merged

SWI-7167 - Replacing ubuntu-20.04 by ubuntu-24.04 on test-pr workflow #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2df09fc
SWI-7167 - Replacing ubuntu-20.04 by ubuntu-24.04 on test-pr workflow
jgutierrezglez Feb 12, 2025
a7aab14
SWI-7167 - Upgrading Bandwidth/build-notify-slack-action to v2
jgutierrezglez Feb 12, 2025
cdde1ae
SWI-7167 - Updating README.md
jgutierrezglez Feb 12, 2025
1b4022d
update template
ckoegel Feb 12, 2025
109fc42
update test
ckoegel Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
gem build *.gemspec
gem push *.gem

- uses: Bandwidth/build-notify-slack-action@v1.0.0
- uses: Bandwidth/build-notify-slack-action@v2
if: always()
with:
job-status: ${{ job.status }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [windows-2022, windows-2019, ubuntu-20.04, ubuntu-22.04]
ruby-version: ['3.0', 3.1, 3.2, 3.3]
os: [windows-2019, windows-2022, ubuntu-22.04, ubuntu-24.04]
ruby-version: ['3.0','3.1','3.2','3.3']
fail-fast: false
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Notify Slack of Failures
uses: Bandwidth/build-notify-slack-action@v2.0.0
uses: Bandwidth/build-notify-slack-action@v2
with:
job-status: failure
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
[![Ruby Style Guide](https://img.shields.io/badge/code_style-rubocop-brightgreen.svg)](https://github.com/rubocop/rubocop)


| **OS** | **Ruby** |
|:---:|:---:|
| Windows 2019 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Windows 2022 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 20.04 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 22.04 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| **OS** | **Ruby** |
|:------------:|:------------------:|
| Windows 2019 | 3.0, 3.1, 3.2, 3.3 |
| Windows 2022 | 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 22.04 | 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 24.04 | 3.0, 3.1, 3.2, 3.3 |

Bandwidth - the Ruby gem for the Bandwidth SDK

Expand Down
12 changes: 6 additions & 6 deletions custom_templates/README.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
[![Ruby Style Guide](https://img.shields.io/badge/code_style-rubocop-brightgreen.svg)](https://github.com/rubocop/rubocop)


| **OS** | **Ruby** |
|:---:|:---:|
| Windows 2019 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Windows 2022 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 20.04 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 22.04 | 2.7, 3.0, 3.1, 3.2, 3.3 |
| **OS** | **Ruby** |
|:------------:|:------------------:|
| Windows 2019 | 3.0, 3.1, 3.2, 3.3 |
| Windows 2022 | 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 22.04 | 3.0, 3.1, 3.2, 3.3 |
| Ubuntu 24.04 | 3.0, 3.1, 3.2, 3.3 |

{{moduleName}} - the Ruby gem for the {{appName}} SDK

Expand Down
2 changes: 1 addition & 1 deletion spec/unit/client/api_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@
response = double('response', headers: headers, body: '{id 1}')
expect {
api_client_default.deserialize(response, 'Hash<String, Integer>')
}.to raise_error(JSON::ParserError, 'unexpected token at \'{id 1}]\'')
}.to raise_error(JSON::ParserError)
end

it 'rescues invalid JSON when expecting non-JSON' do
Expand Down