fix the issue of conflicting types that occur with ArduinoCore-samd, …#18
Open
ahmedalkabir wants to merge 1 commit intoBareConductive:publicfrom
Open
fix the issue of conflicting types that occur with ArduinoCore-samd, …#18ahmedalkabir wants to merge 1 commit intoBareConductive:publicfrom
ahmedalkabir wants to merge 1 commit intoBareConductive:publicfrom
Conversation
…and a few improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and a few improvements.
I did some fixes to the code to make it possible to work with Arduino MKR1000, and I guess it's going to work well with any platform based on ArduinoCore because it uses "PinMode" user-defined type, thus I made mpr121_pinf_type a strong type by providing a class keyword with enum.
I've tested on Arduino MKR1000 and Arduino UNO and work like a charm.