theme/gitline: harmonize powerline.base file(s)
#2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/powerline.base
branch
2 times, most recently
from
72992bc
to
b7e8434
Compare
gaelicWizard
changed the title
powerline.base file(s)
gaelicWizard
force-pushed
the
theme/powerline.base
branch
4 times, most recently
from
824a4f4
to
6e37d22
Compare
gaelicWizard
force-pushed
the
theme/powerline.base
branch
3 times, most recently
from
3641796
to
fe5528f
Compare
|
why wouldnt we remove the duplication here altogether? how different is |
|
It adds hardcoded foreground colors to nearly every prompt segment. By harmonizing the files, I can see the ~15 or so differences that are different very easily. But, I don't have enough experience with the power line themes to be confident about making substantive changes. The goal is definitely to remove the duplicate file, but only after making sure we're not losing capability or breaking anything. Besides, this alsö adds several possible segments to gitline that were previously not available. |
gaelicWizard
force-pushed
the
theme/powerline.base
branch
from
fe5528f
to
ffffc32
Compare
`theme/gitline` appears to have copied an older(?) version of `powerline/powerline.base`. I'd like to eliminate the duplicate, so this is the first step. - Add functions from `powerline/powerline.base` to `gitline/powerline.base`. These functions are NOT hooked up yet. - Bring `__powerline_left_segment()` and `__powerline_prompt_command()` closer together. - handle unbound parameters - fix `$POWERLINE_COMPACT` behavior to consistently match documentation - local some variables
- set default `$POWERLINE_PROMPT`
gaelicWizard
force-pushed
the
theme/powerline.base
branch
from
ffffc32
to
0cee7ef
Compare
seefood
requested changes
Nov 5, 2024
seefood
approved these changes
Nov 7, 2024
seefood
added
seems abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
theme/gitline/powerline.baseandtheme/powerline/powerline.baseto match more closely. Alsö, linttheme/gitline.Motivation and Context
Of all the powerline-based themes,
theme/gitlinehad a whole copy ofpowerline.base.bash. By updating them to match more closely, we may be able to eliminate the duplicate file in the future.How Has This Been Tested?
Since I haven't used the powerline* themes much, this is hard for me to test as I'm not used to what "normal" looks like.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.