-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Plugins: bail early with descriptive messages #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gaelicWizard
wants to merge
9
commits into
Bash-it:master
Choose a base branch
from
gaelicWizard:plugins-bail
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
030c379
to
ccd1bb7
Compare
9995526
to
b9e1535
Compare
b9e1535
to
804a911
Compare
8609f5c
to
b535ffc
Compare
571021a
to
1646e5c
Compare
1646e5c
to
c959322
Compare
c959322
to
5dc6658
Compare
NoahGorny
reviewed
Mar 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gaelicWizard, how can we make sure that nothing is broken? this seems fine to me but this is changing a lot of plugins
care to merge from root? at least 3 conflicts... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clean up
seems abandoned
rattle the cage, and close if nobody wants to keep it going
waiting-for-response
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many plugins/completions/whatever check if their associated command is already installed before loading. Find, fix, and add in/to all the plugins to ensure consistency and improve
bash-it doctor
.Motivation and Context
The
_command_exist()
(et al) functions were all weird due to having logging shoved in sideways, which was neither informative nor used anywhere. This pulls the logging from the utility functions and adds it to the relevant call sites, as well as adding to several other plugins that could use it.In particular, some completions or some plugins may be useless but harmless if their associated command is not installed. I've opted to add logging, but not to force an early short-circuit. For example, I've made improvements to a lot of the completions code recently, but I don't have all the relevant tools installed. I load the completion and can test it out anyway, so I don't want to unnecessarily short-circuit it.
The result of all this should be a more reasonable output when
$BASH_IT_LOG_LEVEL
is set, and frombash-it doctor
, as well as avoid polluting theme variables that check for installed utilities.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.