-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate declaration of grm
, update grb<*>
#2220
Conversation
This PR fixes a bug. The changes have been extensively discussed. The only thing missing it someone to press the Merge button. Please? 🙏 |
Can anyone clarify why for macos-11 tests are skipped, which makes the test job fail? 52 tests are skipped: (3 + 46 + 3)
Log excerpt (macos-11)
Skipped tests (macos-11)
Is this relevant and needs fixing, or is this an operational error or a flaky test suite? |
@bittner I don't have an answer for why the macos tests do this, but it is my understanding that yes, they need fixing. |
Can we first merge all the other git-alias related PRs? My hope is that after rebasing onto those changesets the tests run successfully, PRs like this one either succeed (by magic, i.e. we have flaky tests) or the reasons for failing will become clearer. |
Description
Consolidates the
git rebase
aliases thus fixing the unintended overloading ofgrm
.gdel
is outphased as an unclear, non-intuitive sibling ofgbD
(git branch --delete --force).Motivation and Context
grm
is an alias forgit rebase
due to being redeclared after the firstgrm
(git rm). The redeclaration is a bug.Closes #2160.
How Has This Been Tested?
n/a
Screenshots (if appropriate):
n/a
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.