Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing FieldMultiSelect ChakraProps part #566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Duriel7
Copy link
Member

@Duriel7 Duriel7 commented Mar 14, 2025

Describe your changes

I just removed the isDisabled just below the placeholder. It prevented the user to effectively see the demonstration of ChakraProps in the component storybook.
See first screenshot for visual proof and second screenshot for the original code I modified in the push.
Link to the file : https://github.com/BearStudio/start-ui-web/blob/master/src/components/Form/FieldMultiSelect/docs.stories.tsx line 128

Screenshots

FieldMultiSelect ChakraProps unavailable
FieldMultiSelect Chalra Props disabled

Documentation

Not applicable here.

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the multi-select field to be interactive, allowing users to make selections rather than encountering a disabled, unresponsive control.

Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 4:08pm
start-ui-web-restart ❌ Failed (Inspect) Mar 14, 2025 4:08pm

Copy link
Contributor

coderabbitai bot commented Mar 14, 2025

Walkthrough

The change removes the isDisabled prop from the FormFieldController component in the ChakraProps story within the multi-select field documentation. This update allows the multi-select field to be interactive by no longer forcing it to be disabled. No modifications were made to exported or public declarations.

Changes

File Change Summary
src/components/Form/FieldMultiSelect/docs.stories.tsx Removed the isDisabled prop from the FormFieldController component in the ChakraProps story, enabling user interaction on the field.

Suggested reviewers

  • ivan-dalmet

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24d2f62 and bf070bb.

📒 Files selected for processing (1)
  • src/components/Form/FieldMultiSelect/docs.stories.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/components/Form/FieldMultiSelect/docs.stories.tsx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Lint and Type Check (20)
  • GitHub Check: Lint and Type Check (22)
  • GitHub Check: Lint and Type Check (lts/*)
  • GitHub Check: Playwright E2E Tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant