-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update setting.json in readme #567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request updates the i18n Ally configuration by modifying the locales paths in the VS Code settings. The Changes
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
166-169
: Expand i18n Ally Locales PathsThe update correctly expands the
"i18n-ally.localesPaths"
array to include both the local"src/locales"
directory and the external"node_modules/zod-i18n-map/locales"
folder. This aligns with the feedback from PR 565, allowing the i18n Ally extension to recognize locale files located in both directories.A minor suggestion: consider adding a brief inline comment within this JSON snippet (or in the surrounding documentation) explaining the purpose of including the external locales path. This can help future maintainers understand why the additional path was added.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Lint and Type Check (20)
- GitHub Check: Playwright E2E Tests
- GitHub Check: Lint and Type Check (lts/*)
- GitHub Check: Lint and Type Check (22)
Based on @vanenshi feedback #565
Summary by CodeRabbit