Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): Make the banner behavior (one or many visible) configuration #1450

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

Belphemur
Copy link
Owner

Fixes #1441

…f notification is reached.

refactor: add safeguard for avoiding bad values

feat(banner): add settings to only have one banner as before (disabled by default)

refactor: hide setting if not banner
@Belphemur Belphemur requested a review from XangelMusic April 11, 2024 00:47
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Qodana for .NET

2 new problems were found

Inspection name Severity Problems
Method return value is never used (private accessibility) 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@XangelMusic XangelMusic merged commit f4ac551 into dev Apr 11, 2024
12 checks passed
@Belphemur Belphemur deleted the 1441-notification-banner-config branch April 11, 2024 03:34
Copy link
Contributor

github-actions bot commented May 7, 2024

🎉 This PR is included in version 6.11.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Currently selected audio device" toasts are duplicated in latest update
2 participants