fix(responses-api): apply drop_params for GPT-5 temperature validation #16545
+143
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply model-specific parameter validation in the Responses API to respect drop_params setting for GPT-5 temperature constraints. Changes: - Modified OpenAIResponsesAPIConfig.map_openai_params() to validate temperature parameter for GPT-5 models - Reuses existing GPT-5 validation logic from chat completions endpoint - GPT-5 only accepts temperature=1, other values are now dropped when drop_params=True or raise error when drop_params=False - Added comprehensive test suite with 7 test cases covering: * temperature != 1 with drop_params enabled/disabled * temperature = 1 (valid value) * gpt-5-codex variant support * non-GPT-5 models remain unaffected * multiple parameters handling This ensures consistent behavior between /v1/chat/completions and /v1/responses endpoints for GPT-5 temperature handling.
|
@Chesars is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(responses-api): apply drop_params for GPT-5
temperature validation
Relevant issues
Fixes #16090
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Problem
The Responses API (
/v1/responses) was not applying model-specific parameter validation. Whiletemperatureis listed in supported params, GPT-5 has a specific constraint (only acceptstemperature=1).The
drop_paramssetting was not being respected because the code wasn't checking model-specific restrictions.Solution
OpenAIResponsesAPIConfig.map_openai_params()to apply model-specific validation for GPT-5OpenAIGPT5Configvalidation logic from chat completions endpointdrop_params=Truecorrectly dropstemperature != 1for GPT-5/v1/chat/completionsand/v1/responsesBreaking Changes
None
Tests Added ✅