Make various improvements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract LoginStatus to its own file
- Ensure AddIdentityApiEndpoints doesn't override the DefaultScheme
…n whenever it's used - Fixed some nullability warnings
- Remove call to Logout when initializing authentication state - Logout when a valid access token cannot be retrieved
halter73
force-pushed
the
halter73/suggestions
branch
from
c33a9cf to
1a2f455
Compare
BethMassi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most if it is non-functional stylistic improvements, but I also fixed the error message when the client fails to log in because the server is down, and fixed the 401 rather than login redirect when you would get upon logout.
The sample now also checks the expiration of the access token each time it's used and refreshes it when necessary. Previously, the access token was only being checked at application start. This can be important if people leave the application open for over an hour which is the default token expiration.