-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature pull request: Mutable SVG object in runtime #70
base: master
Are you sure you want to change the base?
Conversation
Make public of value type classes and all SVG-Tag-related classes Move the value type classes to new files Add getters and setters for public access (Becoz of make it mutable from outside) but package-private direct access to instance variables Minor changes to getElementByXXX methods
Hi. Thanks for posting this. This is an interesting patch. I'm curious how you are using these changes yourself. What is it enabling you to do that you couldn't do before? |
I have 2 major usage:
After the change is set, I render the SVG object into picture, then restore original SVG state and the another change, and so on. |
But the code is not thoroughly tested. I only use it with some tags I've used. You'd better test the code more with your own test case. :P |
Remove caching map of id to element and class name to element (because mutable code not guarantee correct update for now)
This is definitely stale, but it would still be a useful feature. |
I modify your code to make the SVG mutable, Including:
etc.
Please take a look.
I followed you from GoogleCode. You said you will parse it to DOM-tree, I dunno if it is still on. But may be you can accept this first and let people do these things first. After you finish the DOM-tree implementation, you can level up your version to 2.x.x