Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate validation for ODBC driver #32

Closed
wants to merge 14 commits into from

Conversation

Yury-Fridlyand
Copy link

Description

  • Having this fix driver doesn't ignore user preferences for Hostname Verification parameter, and once it unset driver can establish SSL connection even if self-signed certificates are used
  • AWS SDK compilation workflow changed to use libcurl instead of winhttp as a transport library
    • libcurl shipped by vcpkg according to the doc
  • AWS SDK updated
  • Fixed crash in driver caused by improper libcurl resource release (incorrect order)

This PR has all changes from PRs opensearch-project#28, opensearch-project#29 and opensearch-project#30 collected alltogether.

Issues Resolved

opendistro-for-elasticsearch/sql#686
opendistro-for-elasticsearch/sql#783
opensearch-project/sql-odbc#15
opensearch-project/sql-odbc#8
Applicable for ODFE too

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 14 commits February 22, 2022 21:34
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
Signed-off-by: Yury Fridlyand <[email protected]>
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #32 (643d27e) into main (8b58136) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      opensearch-project/sql#32   +/-   ##
=========================================
  Coverage     99.92%   99.92%           
  Complexity     2698     2698           
=========================================
  Files           257      257           
  Lines          6491     6491           
  Branches        402      402           
=========================================
  Hits           6486     6486           
  Misses            5        5           
Flag Coverage Δ
sql-engine 99.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b58136...643d27e. Read the comment docs.

@Yury-Fridlyand Yury-Fridlyand deleted the odbc-fix-certificate-validation branch June 17, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants