webhid: avoid unecessary device selection prompt if device already connected #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
force-pushed
the
fix-webhid-connection
branch
from
50ac31f to
3adfd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: if connecting through webhid, browser keeps showing prompt to select device even though the device has already been paired. This PR fixes that behavior and reuses existing pairing, avoiding the redundant prompt.
Ledger js library works similarly:
https://github.com/LedgerHQ/ledger-live/blob/a77b0c1236302f4fb58b61cf7d0df5632cdc86e1/libs/ledgerjs/packages/hw-transport-webhid/src/TransportWebHID.ts#L110
https://github.com/LedgerHQ/ledger-live/blob/a77b0c1236302f4fb58b61cf7d0df5632cdc86e1/libs/ledgerjs/packages/hw-transport/src/Transport.ts#L295