Qt 6.8 -> release-v4.47.0 #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moq requires 1.22.5, so it is downloaded automatically in addition to 1.22.4 when building the image.
Reason: Moonpay widget login says "you can't perform this action", fixed by a newer Chromium Version. Qt 6.5 was not new enough, but Qt 6.8 is. This bumps the min requirements for Ubuntu from 20.04 to 22.04, and for macOS from 10.14 to 12: https://doc.qt.io/qt-6/supported-platforms.html Various changes were needed: - macos bumped to 14, required for building as per the above link - the webclass being in a different worker thread caused a SIGTRAP. Since our backend calls are anyway launched in goroutines (a change done after moving webclass to a thread), we can keep this in the main thread as dispatching the call is low overhead. - qwebchannel.js update is taken from https://raw.githubusercontent.com/qt/qtwebchannel/refs/tags/v6.8.2/examples/webchannel/shared/qwebchannel.js. The only local modification is to `export const QWebChannel` and drop the manual export like in 407bb24 - libxcb-cursor0 is newly required on linux - on linux, v8_context_snapshot.bin is manually copied to the target as linuxdeployqt has not been fixed yet to do it automatically, required for QtWebEngine to launch
``` .\main.cpp(113): warning C4100: 'type': unreferenced formal parameter ..\main.cpp(117): warning C4100: 'level': unreferenced formal parameter ..\main.cpp(188): warning C4129: '.': unrecognized character escape sequence ..\main.cpp(188): warning C4129: '#': unrecognized character escape sequence ..\main.cpp(189): warning C4129: '.': unrecognized character escape sequence ..\main.cpp(189): warning C4129: '#': unrecognized character escape sequence ..\main.cpp(269): warning C4996: 'Qt::AA_EnableHighDpiScaling': High-DPI scaling is always enabled. This attribute no longer has any effect. ..\main.cpp(445): warning C4996: 'QWebEnginePage::MediaVideoCapture': Use QWebEnginePermission::PermissionType::MediaVideoCapture instead ..\main.cpp(450): warning C4996: 'QWebEnginePage::PermissionGrantedByUser': Use QWebEnginePermission::State::Granted instead ..\main.cpp(447): warning C4996: 'QWebEnginePage::setFeaturePermission': Setting permissions through QWebEnginePage has been deprecated. Please use QWebEnginePermission instead. ..\main.cpp(505): warning C4100: 'instanceId': unreferenced formal parameter ..\main.cpp(443): warning C4996: 'QWebEnginePage::featurePermissionRequested': The signal has been deprecated; please use permissionRequested instead. ```
We ported the Windows build to Github Actions a while ago, so this is redudnant. Dropping now as we bumped Qt to 6.8 and there is no need to spend time doing the same in appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3200 but to the release branch.